Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: components/arc/common/ime.mojom

Issue 2136933002: Add ime.ExtendSelectionAndDelete Mojo RPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add ime.ExtendSelectionAndDelete Mojo RPC Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/arc/ime/arc_ime_bridge.h » ('j') | components/arc/ime/arc_ime_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/common/ime.mojom
diff --git a/components/arc/common/ime.mojom b/components/arc/common/ime.mojom
index a3620ea3f712401f365c7b9f1c252073dc00e342..13fd4004cf6c20eecb64dea657abd6ae69629fd1 100644
--- a/components/arc/common/ime.mojom
+++ b/components/arc/common/ime.mojom
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Next MinVersion: 4
+// Next MinVersion: 5
module arc.mojom;
@@ -42,6 +42,7 @@ struct CompositionSegment {
bool emphasized;
};
+// Next method ID: 4
interface ImeHost {
// Notifies Chrome that the text input focus is changed.
OnTextInputTypeChanged@0(TextInputType type);
@@ -56,6 +57,7 @@ interface ImeHost {
[MinVersion=2] ShowImeIfNeeded@3();
};
+// Next method ID: 6
interface ImeInstance {
Init@0(ImeHost host_ptr);
@@ -73,4 +75,9 @@ interface ImeInstance {
// screen coordinate, physical pixel as a unit.
// When all members are zero value, virtual keyboard is being hidden.
[MinVersion=3] OnKeyboardBoundsChanging@4(ScreenRect new_bounds);
+
kinaba 2016/07/11 07:43:56 nit: 1 blank line (not 2)
takaoka 2016/07/11 08:34:55 Done.
+
+ // Deletes current selection plus the specified number of characters before
kinaba 2016/07/11 07:43:56 Could you elaborate more on the "number of charact
takaoka 2016/07/11 08:34:55 Confirmed that "characters" means char16.https://c
+ // and after selection or caret.
+ [MinVersion=4] ExtendSelectionAndDelete@5(uint32 before, uint32 after);
};
« no previous file with comments | « no previous file | components/arc/ime/arc_ime_bridge.h » ('j') | components/arc/ime/arc_ime_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698