Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 213683006: Settings Override API: localize all URLs. (Closed)

Created:
6 years, 8 months ago by vasilii
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, battre
Visibility:
Public.

Description

Settings Override API: localize all URLs. Currently the search provider can be localized. The CL adds localization support of homepage and startup page. BUG=267510 R=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260116

Patch Set 1 : all #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M chrome/browser/extensions/api/settings_overrides/settings_overrides_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util_unittest.cc View 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/settings_override/manifest.json View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/manifest_constants.h View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/common/manifest_constants.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
vasilii
Benjamin, please review.
6 years, 8 months ago (2014-03-27 15:44:54 UTC) #1
not at google - send to devlin
lgtm
6 years, 8 months ago (2014-03-27 15:48:12 UTC) #2
vasilii
The CQ bit was checked by vasilii@chromium.org
6 years, 8 months ago (2014-03-27 17:41:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/213683006/60001
6 years, 8 months ago (2014-03-27 17:41:25 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 22:16:49 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-27 22:16:50 UTC) #6
battre
The CQ bit was checked by battre@chromium.org
6 years, 8 months ago (2014-03-28 07:24:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/213683006/60001
6 years, 8 months ago (2014-03-28 07:25:50 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 12:12:10 UTC) #9
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, content_unittests, crypto_unittests, url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=137146
6 years, 8 months ago (2014-03-28 12:12:11 UTC) #10
vasilii
6 years, 8 months ago (2014-03-28 13:28:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 manually as r260116 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698