Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3936)

Unified Diff: chrome/common/extensions/extension_l10n_util_unittest.cc

Issue 213683006: Settings Override API: localize all URLs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: all Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_l10n_util_unittest.cc
diff --git a/chrome/common/extensions/extension_l10n_util_unittest.cc b/chrome/common/extensions/extension_l10n_util_unittest.cc
index c5ed18a96ce4cecd9946f20f0b9625c02586dc5d..442fec0bcd297ae0b1fdb4f2bbcc8da6d64c2a4c 100644
--- a/chrome/common/extensions/extension_l10n_util_unittest.cc
+++ b/chrome/common/extensions/extension_l10n_util_unittest.cc
@@ -575,7 +575,13 @@ TEST(ExtensionL10nUtil, LocalizeManifestWithSearchProviderMsgs) {
search_provider->SetString("search_url", "http://www.foo.__MSG_country__");
search_provider->SetString("favicon_url", "http://www.foo.__MSG_country__");
search_provider->SetString("suggest_url", "http://www.foo.__MSG_country__");
- manifest.Set(keys::kSearchProvider, search_provider);
+ manifest.Set(keys::kOverrideSearchProvider, search_provider);
+
+ manifest.SetString(keys::kOverrideHomepage, "http://www.foo.__MSG_country__");
+
+ base::ListValue* startup_pages = new base::ListValue;
+ startup_pages->AppendString("http://www.foo.__MSG_country__");
+ manifest.Set(keys::kOverrideStartupPage, startup_pages);
std::string error;
scoped_ptr<MessageBundle> messages(CreateManifestBundle());
@@ -590,7 +596,7 @@ TEST(ExtensionL10nUtil, LocalizeManifestWithSearchProviderMsgs) {
ASSERT_TRUE(manifest.GetString(keys::kDescription, &result));
EXPECT_EQ("description", result);
- std::string key_prefix(keys::kSearchProvider);
+ std::string key_prefix(keys::kOverrideSearchProvider);
key_prefix += '.';
ASSERT_TRUE(manifest.GetString(key_prefix + "name", &result));
EXPECT_EQ("de", result);
@@ -607,6 +613,13 @@ TEST(ExtensionL10nUtil, LocalizeManifestWithSearchProviderMsgs) {
ASSERT_TRUE(manifest.GetString(key_prefix + "suggest_url", &result));
EXPECT_EQ("http://www.foo.de", result);
+ ASSERT_TRUE(manifest.GetString(keys::kOverrideHomepage, &result));
+ EXPECT_EQ("http://www.foo.de", result);
+
+ ASSERT_TRUE(manifest.GetList(keys::kOverrideStartupPage, &startup_pages));
+ ASSERT_TRUE(startup_pages->GetString(0, &result));
+ EXPECT_EQ("http://www.foo.de", result);
+
EXPECT_TRUE(error.empty());
}
« no previous file with comments | « chrome/common/extensions/extension_l10n_util.cc ('k') | chrome/test/data/extensions/settings_override/manifest.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698