Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2136813002: mac: Update knowledge of CFAllocator internals for 10.12 (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

mac: Update knowledge of CFAllocator internals for 10.12 For each new major OS version, we need to poke at the internals of CFAllocator to enable the out-of-memory killer for the default CFAllocator implementations. This update is for macOS 10.12 ("Sierra"), whose CFAllocator internals are unchanged from 10.11 (and from 10.9, and in fact from 10.7). It also updates the base::mac::IsOS*() family of functions for this new OS version. BUG=626536, 45650 TEST=base_unittests OutOfMemoryDeathTest.CFAllocator*,MacUtilTest.IsOSEllipsis Review-Url: https://codereview.chromium.org/2129273002 Cr-Commit-Position: refs/heads/master@{#404471} (cherry picked from commit fd1cb64d5070bd041e86434e91a8cca796414367) Committed: https://chromium.googlesource.com/chromium/src/+/bddd17b05548466f7995d583686f479bc107f140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -37 lines) Patch
M base/mac/mac_util.h View 2 chunks +23 lines, -5 lines 0 comments Download
M base/mac/mac_util.mm View 2 chunks +16 lines, -18 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 3 chunks +25 lines, -4 lines 0 comments Download
M base/process/memory_mac.mm View 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mark Mentovai
4 years, 5 months ago (2016-07-10 03:06:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bddd17b05548466f7995d583686f479bc107f140.

Powered by Google App Engine
This is Rietveld 408576698