Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2129273002: mac: Update knowledge of CFAllocator internals for 10.12 (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Update knowledge of CFAllocator internals for 10.12 For each new major OS version, we need to poke at the internals of CFAllocator to enable the out-of-memory killer for the default CFAllocator implementations. This update is for macOS 10.12 ("Sierra"), whose CFAllocator internals are unchanged from 10.11 (and from 10.9, and in fact from 10.7). It also updates the base::mac::IsOS*() family of functions for this new OS version. BUG=626536, 45650 TEST=base_unittests OutOfMemoryDeathTest.CFAllocator*,MacUtilTest.IsOSEllipsis Committed: https://crrev.com/fd1cb64d5070bd041e86434e91a8cca796414367 Cr-Commit-Position: refs/heads/master@{#404471}

Patch Set 1 #

Patch Set 2 : Diet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -37 lines) Patch
M base/mac/mac_util.h View 2 chunks +23 lines, -5 lines 0 comments Download
M base/mac/mac_util.mm View 1 2 chunks +16 lines, -18 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 3 chunks +25 lines, -4 lines 0 comments Download
M base/process/memory_mac.mm View 1 chunk +5 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
Mark Mentovai
4 years, 5 months ago (2016-07-08 18:14:05 UTC) #2
erikchen
lgtm
4 years, 5 months ago (2016-07-08 18:19:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129273002/20001
4 years, 5 months ago (2016-07-08 18:24:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 19:59:12 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 19:59:25 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fd1cb64d5070bd041e86434e91a8cca796414367 Cr-Commit-Position: refs/heads/master@{#404471}
4 years, 5 months ago (2016-07-08 20:01:07 UTC) #9
Avi (use Gerrit)
4 years, 5 months ago (2016-07-08 21:01:26 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698