Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2136763002: DevTools: Sort execution contexts in nested frames (Closed)

Created:
4 years, 5 months ago by einbinder
Modified:
4 years, 2 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Sort execution contexts in nested frames BUG=626415 Committed: https://crrev.com/1a9d978d3de0281a9164f7b4d9e69e75d81f581b Cr-Commit-Position: refs/heads/master@{#404935}

Patch Set 1 #

Total comments: 14

Patch Set 2 : Refactor and fix flaky test #

Total comments: 1

Patch Set 3 : style #

Patch Set 4 : Fix merge conflict #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/resources/execution-context-iframe1.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/resources/execution-context-iframe2.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js View 1 2 3 2 chunks +45 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 2 3 4 chunks +23 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 2 3 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 31 (13 generated)
einbinder
4 years, 5 months ago (2016-07-09 01:42:14 UTC) #2
pfeldman
https://codereview.chromium.org/2136763002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html File third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html (right): https://codereview.chromium.org/2136763002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html#newcode9 third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html:9: for (var c of contexts){ space before { missing ...
4 years, 5 months ago (2016-07-09 02:02:09 UTC) #3
einbinder
ptal https://codereview.chromium.org/2136763002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html File third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html (right): https://codereview.chromium.org/2136763002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html#newcode9 third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html:9: for (var c of contexts){ On 2016/07/09 02:02:08, ...
4 years, 5 months ago (2016-07-11 18:40:15 UTC) #4
pfeldman
lgtm https://codereview.chromium.org/2136763002/diff/20001/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html File third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html (right): https://codereview.chromium.org/2136763002/diff/20001/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html#newcode9 third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html:9: for (var c of contexts) { nit style: ...
4 years, 5 months ago (2016-07-11 20:34:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136763002/40001
4 years, 5 months ago (2016-07-11 21:42:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/33790) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-11 21:46:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136763002/60001
4 years, 5 months ago (2016-07-11 22:03:48 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242016) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-11 23:33:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136763002/60001
4 years, 5 months ago (2016-07-12 01:30:30 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260539)
4 years, 5 months ago (2016-07-12 03:07:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136763002/60001
4 years, 5 months ago (2016-07-12 17:37:16 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261183)
4 years, 5 months ago (2016-07-12 20:07:28 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136763002/60001
4 years, 5 months ago (2016-07-13 00:29:35 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-13 02:54:25 UTC) #26
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 02:54:49 UTC) #27
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/1a9d978d3de0281a9164f7b4d9e69e75d81f581b Cr-Commit-Position: refs/heads/master@{#404935}
4 years, 5 months ago (2016-07-13 02:58:04 UTC) #29
pfeldman
https://codereview.chromium.org/2136763002/diff/60001/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right): https://codereview.chromium.org/2136763002/diff/60001/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js#newcode200 third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:200: target.runtimeModel = new WebInspector.RuntimeModel(target); With this, we broke one ...
4 years, 2 months ago (2016-10-14 14:36:25 UTC) #30
einbinder
4 years, 2 months ago (2016-10-14 18:07:38 UTC) #31
Message was sent while issue was closed. 
https://codereview.chromium.org/2136763002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2136763002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:200:
target.runtimeModel = new WebInspector.RuntimeModel(target);
On 2016/10/14 at 14:36:25, pfeldman wrote:
> With this, we broke one of the decorator assumptions - upon context creation,
we receive the frameId that has not been reported to the front-end (we
initialize resourceTreeModel below). This results in blank execution context
names. Do you remember why we moved it here?

The ResourceTreeModel injects a callback into the runtimeModel for sorting
execution contexts by frames.

Powered by Google App Engine
This is Rietveld 408576698