third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js - Issue 2136763002: DevTools: Sort execution contexts in nested frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js

Issue 2136763002: DevTools: Sort execution contexts in nested frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix merge conflict Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/resources/execution-context-iframe2.html ('k') | third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js

index e9fc42f18cbeff48b8ee9ad1efff0e47d21beb67..1da29b93db0bba4a73359ff5283ee8120efff48d 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js

@@ -63,7 +63,7 @@ WebInspector.ConsoleContextSelector.prototype = {

this._optionByExecutionContext.set(executionContext, newOption);

var options = this._selectElement.options;

var contexts = Array.prototype.map.call(options, mapping);

- var index = contexts.lowerBound(executionContext, WebInspector.ExecutionContext.comparator)

+ var index = contexts.lowerBound(executionContext, executionContext.runtimeModel.executionContextComparator())

this._selectElement.insertBefore(newOption, options[index]);

if (executionContext === WebInspector.context.flavor(WebInspector.ExecutionContext))