[DirectWrite] Force full hinting for certain fonts

[DirectWrite] Force full hinting for certain fonts

Change FontCacheSkiaWin to force the use of full hinting (which in turn
will trigger GDI style rendering with the next skia update) for certain
fonts. The list of fonts is limited to "Courier New" for now but will
likely need to be expanded somewhat.

R=cpu@chromium.org
BUG=357864
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170668

[Stephen White, 2014-04-02 14:04:35]

LGTM. This seems unfortunate, though. Is there a way to characterize which fonts
require this? How do other browsers look with Courier New and others?

[eae, 2014-04-02 15:45:36]

On 2014/04/02 14:04:35, Stephen White wrote:
> LGTM. This seems unfortunate, though. Is there a way to characterize which
fonts
> require this? How do other browsers look with Courier New and others?

Yes, it is rather unfortunate and is hopefully only a stop-gap measure. 
Mozilla forces GDI for Arial,Consolas,Courier New,Microsoft Sans Serif,Segoe
UI,Tahoma,Trebuchet MS,Verdana. IE renders those font differently than we do
with DirectWrite but I haven't yet been able to determine exactly what they are
doing.

[eae, 2014-04-02 15:52:46]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-04-02 15:52:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eae@chromium.org/213673011/40001

[commit-bot: I haz the power, 2014-04-02 16:17:42]

Change committed as 170668

[Stephen White, 2014-05-28 13:12:51]

(ancient comment, but apparently I never sent it, so...)

https://codereview.chromium.org/213673011/diff/40001/Source/platform/fonts/wi...
File Source/platform/fonts/win/FontCacheSkiaWin.cpp (right):

https://codereview.chromium.org/213673011/diff/40001/Source/platform/fonts/wi...
Source/platform/fonts/win/FontCacheSkiaWin.cpp:227: if
(equalIgnoringCase(familyName, courierNew))
BTW, it looks from the code like a case-insensitive comparison of AtomicString
doesn't get hashed. I guess this can't be case-sensitive?

[eae, 2014-05-28 16:20:01]

On 2014/05/28 13:12:51, Stephen White wrote:
> (ancient comment, but apparently I never sent it, so...)
> 
>
https://codereview.chromium.org/213673011/diff/40001/Source/platform/fonts/wi...
> File Source/platform/fonts/win/FontCacheSkiaWin.cpp (right):
> 
>
https://codereview.chromium.org/213673011/diff/40001/Source/platform/fonts/wi...
> Source/platform/fonts/win/FontCacheSkiaWin.cpp:227: if
> (equalIgnoringCase(familyName, courierNew))
> BTW, it looks from the code like a case-insensitive comparison of AtomicString
> doesn't get hashed. I guess this can't be case-sensitive?

Good question. This code has been replace by heuristics inspecting the font
looking for embedded bitmaps. We no longer have the font name lookup.