[DirectWrite] Force full hinting for certain fonts

Source/platform/fonts/win/FontCacheSkiaWin.cpp

 /*
  * Copyright (C) 2006, 2007 Apple Computer, Inc.
  * Copyright (c) 2006, 2007, 2008, 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 203 matching lines @@
     case USCRIPT_ARMENIAN:
     case USCRIPT_THAANA:
     case USCRIPT_CANADIAN_ABORIGINAL:
     case USCRIPT_CHEROKEE:
     case USCRIPT_MONGOLIAN:
     default:
         return 0;
     }
 }
 
+static bool fontRequiresFullHinting(const AtomicString& familyName)
+{
+    DEFINE_STATIC_LOCAL(AtomicString, courierNew, ("Courier New", AtomicString::ConstructFromLiteral));
+    if (equalIgnoringCase(familyName, courierNew))

[Stephen White, 2014/05/28 13:12:52]

BTW, it looks from the code like a case-insensitive comparison of AtomicString
doesn't get hashed. I guess this can't be case-sensitive?

+        return true;
+
+    return false;
+}
+
 FontPlatformData* FontCache::createFontPlatformData(const FontDescription& fontDescription, const AtomicString& family, float fontSize)
 {
     CString name;
     RefPtr<SkTypeface> tf = createTypeface(fontDescription, family, name);
     if (!tf)
         return 0;
 
     // Windows will always give us a valid pointer here, even if the face name
     // is non-existent. We have to double-check and see if the family name was
     // really used.
     // FIXME: Do we need to use predefined fonts "guaranteed" to exist
     // when we're running in layout-test mode?
     if (!typefacesMatchesFamily(tf.get(), family)) {
         return 0;
     }
 
     FontPlatformData* result = new FontPlatformData(tf,
         name.data(),
         fontSize,
         fontDescription.weight() >= FontWeightBold && !tf->isBold() || fontDescription.isSyntheticBold(),
         fontDescription.style() == FontStyleItalic && !tf->isItalic() || fontDescription.isSyntheticItalic(),
         fontDescription.orientation(),
         s_useSubpixelPositioning);
 
+    // FIXME: It might be sufficient to set the "full hinting" flag for
+    // CJK instead of forcing aliased rendering.
     if (s_useDirectWrite) {
         result->setMinSizeForAntiAlias(
             minSizeForAntiAlias(fontDescription.script()));
+        if (fontRequiresFullHinting(family))
+            result->setHinting(SkPaint::kFull_Hinting);
     }
 
     return result;
 }
 
 }