Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 213673007: jankometer: Use the stub implementation for non-Windows. (Closed)

Created:
6 years, 8 months ago by sadrul
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, Elliot Glaysher
Visibility:
Public.

Description

jankometer: Use the stub implementation for non-Windows. The jankometer implementation only does anything on Windows. So use the stub implementation (used on mac, android) for linux-aura. Also, remove the gtk related code from jankometer.cc, and rename it to jankometer_win.cc to make it clear that it is used only on Windows. BUG=358751 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261189

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -489 lines) Patch
D chrome/browser/jankometer.cc View 1 chunk +0 lines, -427 lines 0 comments Download
D chrome/browser/jankometer_android.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/jankometer_mac.cc View 1 chunk +0 lines, -13 lines 0 comments Download
A + chrome/browser/jankometer_stub.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A + chrome/browser/jankometer_win.cc View 5 chunks +0 lines, -31 lines 0 comments Download
M chrome/chrome_browser.gypi View 4 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
jam@ Please review (I am not sure who a proper owner reviewer of this should ...
6 years, 8 months ago (2014-04-01 18:52:48 UTC) #1
jam
On 2014/04/01 18:52:48, sadrul wrote: > jam@ Please review (I am not sure who a ...
6 years, 8 months ago (2014-04-02 16:23:17 UTC) #2
sadrul
On 2014/04/02 16:23:17, jam wrote: > On 2014/04/01 18:52:48, sadrul wrote: > > jam@ Please ...
6 years, 8 months ago (2014-04-02 17:00:20 UTC) #3
sky
LGTM
6 years, 8 months ago (2014-04-02 19:48:06 UTC) #4
sadrul
6 years, 8 months ago (2014-04-02 22:06:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r261189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698