Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: chrome/browser/jankometer_win.cc

Issue 213673007: jankometer: Use the stub implementation for non-Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/jankometer_stub.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/jankometer_win.cc
diff --git a/chrome/browser/jankometer.cc b/chrome/browser/jankometer_win.cc
similarity index 93%
rename from chrome/browser/jankometer.cc
rename to chrome/browser/jankometer_win.cc
index a159064b96a9b9913cbf512959f62a4d8b0cf620..2217133d85ac2324e1b574272a5504cf4bdf79b3 100644
--- a/chrome/browser/jankometer.cc
+++ b/chrome/browser/jankometer_win.cc
@@ -48,10 +48,8 @@ const int kMaxIOMessageDelayMs = 400;
// considering it delayed.
const int kMaxMessageProcessingMs = 100;
-#if defined(OS_WIN)
// TODO(brettw) Consider making this a pref.
const bool kPlaySounds = false;
-#endif
//------------------------------------------------------------------------------
// Provide a special watchdog to make it easy to set the breakpoint on this
@@ -164,10 +162,8 @@ void JankObserverHelper::StartProcessingTimers(const TimeDelta& queueing_time) {
if (queueing_time_ > max_message_delay_) {
// Message is too delayed.
queueing_delay_counter_.Increment();
-#if defined(OS_WIN)
if (kPlaySounds)
MessageBeep(MB_ICONASTERISK);
-#endif
}
}
@@ -187,10 +183,8 @@ void JankObserverHelper::EndProcessingTimers() {
TimeDelta::FromMilliseconds(kMaxMessageProcessingMs)) {
// Message took too long to process.
slow_processing_counter_.Increment();
-#if defined(OS_WIN)
if (kPlaySounds)
MessageBeep(MB_ICONHAND);
-#endif
}
// Reset message specific times.
@@ -304,7 +298,6 @@ class UIJankObserver : public base::RefCountedThreadSafe<UIJankObserver>,
helper_.EndProcessingTimers();
}
-#if defined(OS_WIN)
virtual base::EventStatus WillProcessEvent(
const base::NativeEvent& event) OVERRIDE {
if (!helper_.MessageWillBeMeasured())
@@ -330,30 +323,6 @@ class UIJankObserver : public base::RefCountedThreadSafe<UIJankObserver>,
virtual void DidProcessEvent(const base::NativeEvent& event) OVERRIDE {
helper_.EndProcessingTimers();
}
-#elif defined(USE_AURA)
- virtual base::EventStatus WillProcessEvent(
- const base::NativeEvent& event) OVERRIDE {
- return base::EVENT_CONTINUE;
- }
-
- virtual void DidProcessEvent(const base::NativeEvent& event) OVERRIDE {
- }
-#elif defined(TOOLKIT_GTK)
- virtual void WillProcessEvent(GdkEvent* event) OVERRIDE {
- if (!helper_.MessageWillBeMeasured())
- return;
- // TODO(evanm): we want to set queueing_time_ using
- // gdk_event_get_time, but how do you convert that info
- // into a delta?
- // guint event_time = gdk_event_get_time(event);
- base::TimeDelta queueing_time = base::TimeDelta::FromMilliseconds(0);
- helper_.StartProcessingTimers(queueing_time);
- }
-
- virtual void DidProcessEvent(GdkEvent* event) OVERRIDE {
- helper_.EndProcessingTimers();
- }
-#endif
private:
friend class base::RefCountedThreadSafe<UIJankObserver>;
« no previous file with comments | « chrome/browser/jankometer_stub.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698