Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2136613002:
Corrected test for gcc/libc++ workaround. (Closed)
|
Created:
4 years, 5 months ago by bungeman-skia Modified:
4 years, 5 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionCorrected test for gcc/libc++ workaround.
NOTREECHECKS=true
NOTRY=true
The presubmit bot is all hung up.
Committed: https://skia.googlesource.com/skia/+/7ad42cfe87d07f20e629be5685b1507df931dd9e
Patch Set 1 #Patch Set 2 : Avoid skia_presubmit. #
Messages
Total messages: 32 (22 generated)
Description was changed from ========== Corrected test for gcc/libc++ workaround. ========== to ========== Corrected test for gcc/libc++ workaround. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2136613002 ==========
Description was changed from ========== Corrected test for gcc/libc++ workaround. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2136613002 ========== to ========== Corrected test for gcc/libc++ workaround. ==========
The CQ bit was checked by bungeman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bungeman@google.com changed reviewers: + bsalomon@google.com, herb@google.com, mtklein@google.com
lgtm
The CQ bit was unchecked by bungeman@google.com
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Description was changed from ========== Corrected test for gcc/libc++ workaround. ========== to ========== Corrected test for gcc/libc++ workaround. NOTREECHECKS=true ==========
The CQ bit was unchecked by bungeman@google.com
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bungeman@google.com
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Corrected test for gcc/libc++ workaround. NOTREECHECKS=true ========== to ========== Corrected test for gcc/libc++ workaround. NOTREECHECKS=true NOTRY=true The presubmit bot is all hung up. ==========
The CQ bit was unchecked by bungeman@google.com
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bungeman@google.com
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Corrected test for gcc/libc++ workaround. NOTREECHECKS=true NOTRY=true The presubmit bot is all hung up. ========== to ========== Corrected test for gcc/libc++ workaround. NOTREECHECKS=true NOTRY=true The presubmit bot is all hung up. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2136613002 ==========
The CQ bit was checked by bungeman@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from herb@google.com, bsalomon@google.com Link to the patchset: https://codereview.chromium.org/2136613002/#ps20001 (title: "Avoid skia_presubmit.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Corrected test for gcc/libc++ workaround. NOTREECHECKS=true NOTRY=true The presubmit bot is all hung up. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2136613002 ========== to ========== Corrected test for gcc/libc++ workaround. NOTREECHECKS=true NOTRY=true The presubmit bot is all hung up. ==========
Message was sent while issue was closed.
Description was changed from ========== Corrected test for gcc/libc++ workaround. NOTREECHECKS=true NOTRY=true The presubmit bot is all hung up. ========== to ========== Corrected test for gcc/libc++ workaround. NOTREECHECKS=true NOTRY=true The presubmit bot is all hung up. Committed: https://skia.googlesource.com/skia/+/7ad42cfe87d07f20e629be5685b1507df931dd9e ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/7ad42cfe87d07f20e629be5685b1507df931dd9e |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
