Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: include/core/SkTypes.h

Issue 2136613002: Corrected test for gcc/libc++ workaround. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Avoid skia_presubmit. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2006 The Android Open Source Project 2 * Copyright 2006 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkTypes_DEFINED 8 #ifndef SkTypes_DEFINED
9 #define SkTypes_DEFINED 9 #define SkTypes_DEFINED
10 10
11 // IWYU pragma: begin_exports 11 // IWYU pragma: begin_exports
12 12
13 // In at least two known scenarios when using GCC with libc++: 13 // In at least two known scenarios when using GCC with libc++:
14 // * GCC 4.8 targeting ARMv7 with NEON 14 // * GCC 4.8 targeting ARMv7 with NEON
15 // * GCC 4.9 targeting ARMv8 64 bit 15 // * GCC 4.9 targeting ARMv8 64 bit
16 // we need to typedef float float32_t (or include <arm_neon.h> which does that) 16 // we need to typedef float float32_t (or include <arm_neon.h> which does that)
17 // before #including <memory>. This makes no sense. I'm not very interested in 17 // before #including <memory>. This makes no sense. I'm not very interested in
18 // understanding why... these are old, bizarre platform configuration that we 18 // understanding why... these are old, bizarre platform configuration that we
19 // should just let die. 19 // should just let die.
20 // See https://llvm.org/bugs/show_bug.cgi?id=25608 .
20 #include <ciso646> // Include something innocuous to define _LIBCPP_VERISON if it's libc++. 21 #include <ciso646> // Include something innocuous to define _LIBCPP_VERISON if it's libc++.
21 #if defined(__GNUC__) && __GNUC__ == 4 \ 22 #if defined(__GNUC__) && __GNUC__ == 4 \
22 && ((defined(SK_CPU_ARM32) && defined(SK_ARM_HAS_NEON)) || defined(SK_CPU_ARM64 )) \ 23 && ((defined(__arm__) && (defined(__ARM_NEON__) || defined(__ARM_NEON))) || def ined(__aarch64__)) \
23 && defined(_LIBCPP_VERSION) 24 && defined(_LIBCPP_VERSION)
24 typedef float float32_t; 25 typedef float float32_t;
25 #include <memory> 26 #include <memory>
26 #endif 27 #endif
27 28
28 #include "SkPreConfig.h" 29 #include "SkPreConfig.h"
29 #include "SkUserConfig.h" 30 #include "SkUserConfig.h"
30 #include "SkPostConfig.h" 31 #include "SkPostConfig.h"
31 #include <stddef.h> 32 #include <stddef.h>
32 #include <stdint.h> 33 #include <stdint.h>
(...skipping 682 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 716
716 void* fPtr; 717 void* fPtr;
717 size_t fSize; // can be larger than the requested size (see kReuse) 718 size_t fSize; // can be larger than the requested size (see kReuse)
718 uint32_t fStorage[kSize >> 2]; 719 uint32_t fStorage[kSize >> 2];
719 }; 720 };
720 // Can't guard the constructor because it's a template class. 721 // Can't guard the constructor because it's a template class.
721 722
722 #endif /* C++ */ 723 #endif /* C++ */
723 724
724 #endif 725 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698