Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2136593002: CompositorFrame: Implement ParamTraits versus StructTraits deserialization test (Closed)

Created:
4 years, 5 months ago by Fady Samuel
Modified:
4 years, 5 months ago
Reviewers:
danakj, yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CompositorFrame: Implement ParamTraits versus StructTraits deserialization test This CL times deserialization of the CompositorFrame generated by cc_serialization_perftest using StructTraits versus ParamTraits. This CL also makes some mojo changes to ensure we don't need to move the mojo::Array we are deserializing from. BUG=624459 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/af2b4c9fa1cd5dbe75efa84b91a97f661d0997a1 Cr-Commit-Position: refs/heads/master@{#404498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -18 lines) Patch
M cc/ipc/cc_serialization_perftest.cc View 3 chunks +94 lines, -14 lines 0 comments Download
M mojo/public/cpp/bindings/lib/serialization.h View 2 chunks +5 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Fady Samuel
+yzshen@ for mojo +danakj@ for cc
4 years, 5 months ago (2016-07-08 18:28:40 UTC) #4
yzshen1
lgtm
4 years, 5 months ago (2016-07-08 19:10:39 UTC) #5
danakj
LGTM
4 years, 5 months ago (2016-07-08 19:52:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136593002/1
4 years, 5 months ago (2016-07-08 19:54:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 21:45:46 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 21:45:49 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 21:47:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af2b4c9fa1cd5dbe75efa84b91a97f661d0997a1
Cr-Commit-Position: refs/heads/master@{#404498}

Powered by Google App Engine
This is Rietveld 408576698