mojo/public/cpp/bindings/lib/serialization.h - Issue 2136593002: CompositorFrame: Implement ParamTraits versus StructTraits deserialization test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/serialization.h

Issue 2136593002: CompositorFrame: Implement ParamTraits versus StructTraits deserialization test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/ipc/cc_serialization_perftest.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/lib/serialization.h

diff --git a/mojo/public/cpp/bindings/lib/serialization.h b/mojo/public/cpp/bindings/lib/serialization.h

index 5274adf1a57f32667b5353a9bf3b2b2f188ba339..6d7dd8e5cde032a783c2167d2ef5849de60afce1 100644

--- a/mojo/public/cpp/bindings/lib/serialization.h

+++ b/mojo/public/cpp/bindings/lib/serialization.h

@@ -67,7 +67,7 @@ DataArrayType StructSerializeImpl(UserType* input) {

}

template <typename MojomType, typename DataArrayType, typename UserType>

-bool StructDeserializeImpl(DataArrayType input, UserType* output) {

+bool StructDeserializeImpl(const DataArrayType& input, UserType* output) {

static_assert(BelongsTo<MojomType, MojomTypeCategory::STRUCT>::value,

"Unexpected type.");

using DataType = typename MojomType::Struct::Data_;

@@ -75,7 +75,10 @@ bool StructDeserializeImpl(DataArrayType input, UserType* output) {

if (input.is_null())

return false;

- void* input_buffer = input.empty() ? nullptr : &input.front();

+ void* input_buffer =

+ input.empty()

+ ? nullptr

+ : const_cast<void*>(reinterpret_cast<const void*>(&input.front()));

// Please see comments in StructSerializeImpl.

bool need_copy = !IsAligned(input_buffer);