Remove calls to MessageLoop::current() in base.

Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

Note: Some files outside of base/ had to be modified
because they didn't compile anymore after
#include "base/message_loop/message_loop.h" was removed
from base/ headers.

BUG=616447
TBR=rogerta@chromium.org

Committed: https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd
Cr-Commit-Position: refs/heads/master@{#406378}

[fdoray, 2016-07-08 18:06:23]

Description was changed from

==========
Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
==========

to

==========
Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

Note: Some files outside of base/ had to be modified
because they didn't compile anymore after
#include "base/message_loop/message_loop.h" was removed
from base/ headers.

BUG=616447
==========

[fdoray, 2016-07-08 18:11:27]

fdoray@chromium.org changed reviewers:
+ thestig@chromium.org

[fdoray, 2016-07-08 18:11:28]

Can you review this CL? Thanks.

[Lei Zhang, 2016-07-08 19:21:43]

lgtm, I looked over most of the CL except a few files with a +1 diff.

https://codereview.chromium.org/2136563002/diff/1/base/power_monitor/power_mo...
File base/power_monitor/power_monitor_device_source_win.cc (right):

https://codereview.chromium.org/2136563002/diff/1/base/power_monitor/power_mo...
base/power_monitor/power_monitor_device_source_win.cc:7: #include
"base/power_monitor/power_monitor_device_source.h"
This probably should be first?

https://codereview.chromium.org/2136563002/diff/1/base/threading/thread.h
File base/threading/thread.h (right):

https://codereview.chromium.org/2136563002/diff/1/base/threading/thread.h#new...
base/threading/thread.h:194: // Called to start the message loop
s/message loop/run loop/ ?

[fdoray, 2016-07-08 19:32:21]

fdoray@chromium.org changed reviewers:
+ chcunningham@chromium.org, droger@chromium.org, hashimoto@chromium.org,
jochen@chromium.org, rogerta@chromium.org

[fdoray, 2016-07-08 19:32:22]

jochen@chromium.org: Can you review content/?
hashimoto@chromium.org: Can you review dbus/?
droger@chromium.org: Can you review ios/?
agl@chromium.org: Can you review net/?

caitkp@: TBR for components - only added missing includes
rogerta@: TBR for google_apis - only added missing includes
chcunningham@: TBR for media - only added missing includes

https://codereview.chromium.org/2136563002/diff/1/base/power_monitor/power_mo...
File base/power_monitor/power_monitor_device_source_win.cc (right):

https://codereview.chromium.org/2136563002/diff/1/base/power_monitor/power_mo...
base/power_monitor/power_monitor_device_source_win.cc:7: #include
"base/power_monitor/power_monitor_device_source.h"
On 2016/07/08 19:21:43, Lei Zhang wrote:
> This probably should be first?

Done.

https://codereview.chromium.org/2136563002/diff/1/base/threading/thread.h
File base/threading/thread.h (right):

https://codereview.chromium.org/2136563002/diff/1/base/threading/thread.h#new...
base/threading/thread.h:194: // Called to start the message loop
On 2016/07/08 19:21:43, Lei Zhang wrote:
> s/message loop/run loop/ ?

Done.

[fdoray, 2016-07-08 19:32:57]

Description was changed from

==========
Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

Note: Some files outside of base/ had to be modified
because they didn't compile anymore after
#include "base/message_loop/message_loop.h" was removed
from base/ headers.

BUG=616447
==========

to

==========
Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

Note: Some files outside of base/ had to be modified
because they didn't compile anymore after
#include "base/message_loop/message_loop.h" was removed
from base/ headers.

BUG=616447
TBR=caitkp@chromium.org,rogerta@chromium.org,chcunningham@chromium.org
==========

[fdoray, 2016-07-08 19:34:10]

fdoray@chromium.org changed reviewers:
+ agl@chromium.org, sdefresne@chromium.org
- droger@chromium.org

[fdoray, 2016-07-08 19:34:11]

jochen@chromium.org: Can you review content/?
hashimoto@chromium.org: Can you review dbus/?
sdefresne@chromium.org: Can you review ios/?
agl@chromium.org: Can you review net/?

caitkp@: TBR for components - only added missing includes
rogerta@: TBR for google_apis - only added missing includes
chcunningham@: TBR for media - only added missing includes

[chcunningham, 2016-07-08 19:41:01]

lgtm

[droger, 2016-07-09 23:13:55]

droger@chromium.org changed reviewers:
+ droger@chromium.org

[droger, 2016-07-09 23:13:56]

ios lgtm

[hashimoto, 2016-07-11 03:50:21]

dbus/ lgtm

[jochen (gone - plz use gerrit), 2016-07-11 14:36:32]

lgtm

[agl, 2016-07-11 15:29:19]

net/ LGTM

[fdoray, 2016-07-18 14:45:53]

Description was changed from

==========
Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

Note: Some files outside of base/ had to be modified
because they didn't compile anymore after
#include "base/message_loop/message_loop.h" was removed
from base/ headers.

BUG=616447
TBR=caitkp@chromium.org,rogerta@chromium.org,chcunningham@chromium.org
==========

to

==========
Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

Note: Some files outside of base/ had to be modified
because they didn't compile anymore after
#include "base/message_loop/message_loop.h" was removed
from base/ headers.

BUG=616447
TBR=rogerta@chromium.org
==========

[fdoray, 2016-07-18 14:45:53]

fdoray@chromium.org changed reviewers:
- sdefresne@chromium.org

[fdoray, 2016-07-18 15:03:33]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-07-18 15:03:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, droger@chromium.org, hashimoto@chromium.org,
chcunningham@chromium.org, jochen@chromium.org, agl@chromium.org
Link to the patchset: https://codereview.chromium.org/2136563002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-18 15:03:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 16:34:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 16:34:10]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[fdoray, 2016-07-18 17:19:31]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-07-18 17:19:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 18:43:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 18:43:30]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[fdoray, 2016-07-18 21:32:53]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-07-18 21:34:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 22:18:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 22:18:15]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[fdoray, 2016-07-19 18:35:29]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-07-19 18:35:30]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
hashimoto@chromium.org, thestig@chromium.org, chcunningham@chromium.org,
jochen@chromium.org, agl@chromium.org
Link to the patchset: https://codereview.chromium.org/2136563002/#ps80001
(title: "restore dns_config_service_posix_unittest.cc")

[commit-bot: I haz the power, 2016-07-19 18:36:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roger Tawa OOO till Jul 10th, 2016-07-19 20:07:24]

lgtm google_apis

[commit-bot: I haz the power, 2016-07-19 21:06:10]

Description was changed from

==========
Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

Note: Some files outside of base/ had to be modified
because they didn't compile anymore after
#include "base/message_loop/message_loop.h" was removed
from base/ headers.

BUG=616447
TBR=rogerta@chromium.org
==========

to

==========
Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

Note: Some files outside of base/ had to be modified
because they didn't compile anymore after
#include "base/message_loop/message_loop.h" was removed
from base/ headers.

BUG=616447
TBR=rogerta@chromium.org
==========

[commit-bot: I haz the power, 2016-07-19 21:06:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-19 21:06:25]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 21:08:08]

Description was changed from

==========
Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

Note: Some files outside of base/ had to be modified
because they didn't compile anymore after
#include "base/message_loop/message_loop.h" was removed
from base/ headers.

BUG=616447
TBR=rogerta@chromium.org
==========

to

==========
Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

Note: Some files outside of base/ had to be modified
because they didn't compile anymore after
#include "base/message_loop/message_loop.h" was removed
from base/ headers.

BUG=616447
TBR=rogerta@chromium.org

Committed: https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd
Cr-Commit-Position: refs/heads/master@{#406378}
==========

[commit-bot: I haz the power, 2016-07-19 21:08:10]

Patchset 5 (id:??) landed as
https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd
Cr-Commit-Position: refs/heads/master@{#406378}

[gab, 2016-07-21 19:10:50]

gab@chromium.org changed reviewers:
+ gab@chromium.org

[gab, 2016-07-21 19:10:51]

https://codereview.chromium.org/2136563002/diff/80001/base/threading/thread.h
File base/threading/thread.h (right):

https://codereview.chromium.org/2136563002/diff/80001/base/threading/thread.h...
base/threading/thread.h:247: RunLoop* run_loop_;
Note: this turns out to not be relevant in this specific case but this variable
isn't initialized in constructor, fixed in
https://codereview.chromium.org/2145463002 :-)