Make WindowAndroid a ViewAndroid

Make WindowAndroid a ViewAndroid

This removes the need for tracking a parent view and a window
in each ViewAndroid. Instead the WindowAndroid is now just the root
View.

Committed: https://crrev.com/481b7fe028211025dc673949d4303cee6661e4ec
Cr-Commit-Position: refs/heads/master@{#406881}

[no sievers, 2016-07-11 22:33:18]

Description was changed from

==========
Make WindowAndroid a ViewAndroid

This removes the need for tracking a parent view and a window
in each ViewAndroid. Instead the WindowAndroid is now just the root
View.
==========

to

==========
Make WindowAndroid a ViewAndroid

This removes the need for tracking a parent view and a window
in each ViewAndroid. Instead the WindowAndroid is now just the root
View.
==========

[no sievers, 2016-07-11 22:33:18]

sievers@chromium.org changed reviewers:
+ yusufo@chromium.org

[no sievers, 2016-07-11 22:33:31]

Yusuf, so maybe this is a bit nicer. wdyt?

[Yusuf, 2016-07-13 19:54:36]

Looks good, but one thing that confused me about GetWindowAndroid

https://codereview.chromium.org/2136373002/diff/1/content/browser/android/con...
File content/browser/android/content_view_core_impl.cc (left):

https://codereview.chromium.org/2136373002/diff/1/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:871: ui::WindowAndroid*
ContentViewCoreImpl::GetWindowAndroid() const {
why remove this?

https://codereview.chromium.org/2136373002/diff/1/ui/android/view_android.cc
File ui/android/view_android.cc (right):

https://codereview.chromium.org/2136373002/diff/1/ui/android/view_android.cc#...
ui/android/view_android.cc:60: WindowAndroid* ViewAndroid::GetWindowAndroid() {
GetWindowAndroid will always return null if this is the case, right?

When parent_ has no parent_, we should return the parent?

[no sievers, 2016-07-13 23:32:12]

https://codereview.chromium.org/2136373002/diff/1/content/browser/android/con...
File content/browser/android/content_view_core_impl.cc (left):

https://codereview.chromium.org/2136373002/diff/1/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:871: ui::WindowAndroid*
ContentViewCoreImpl::GetWindowAndroid() const {
On 2016/07/13 19:54:36, Yusuf wrote:
> why remove this?

Done. WindowAndroid::GetWindowAndroid() const override needs to cast away the
constness though now.

https://codereview.chromium.org/2136373002/diff/1/ui/android/view_android.cc
File ui/android/view_android.cc (right):

https://codereview.chromium.org/2136373002/diff/1/ui/android/view_android.cc#...
ui/android/view_android.cc:60: WindowAndroid* ViewAndroid::GetWindowAndroid() {
On 2016/07/13 19:54:36, Yusuf wrote:
> GetWindowAndroid will always return null if this is the case, right?
> 
> When parent_ has no parent_, we should return the parent?

It will return only non-null if the tree actually has a WindowAndroid at the
top. For that I overrode this method in WindowAndroid to return |this|.

[no sievers, 2016-07-13 23:34:32]

The CQ bit was checked by sievers@chromium.org to run a CQ dry run

[Yusuf, 2016-07-13 23:35:19]

lgtm

Thanks! Sorry looks like I read the WindowAndroid method first then forgot about
it.

[commit-bot: I haz the power, 2016-07-13 23:35:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 23:57:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 23:57:47]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[no sievers, 2016-07-20 22:52:28]

The CQ bit was checked by sievers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 22:53:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 23:10:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:10:51]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[no sievers, 2016-07-20 23:17:53]

The CQ bit was checked by sievers@chromium.org

[no sievers, 2016-07-20 23:17:54]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/2136373002/#ps60001
(title: "Make WindowAndroid a ViewAndroid")

[commit-bot: I haz the power, 2016-07-20 23:18:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 23:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:27:43]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[no sievers, 2016-07-20 23:48:37]

sievers@chromium.org changed reviewers:
+ dtrainor@chromium.org

[no sievers, 2016-07-20 23:48:51]

+dtrainor for ui/android stamp

[David Trainor- moved to gerrit, 2016-07-21 15:11:47]

ui/android lgtm!

[no sievers, 2016-07-21 17:00:04]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2016-07-21 17:00:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 17:04:15]

Description was changed from

==========
Make WindowAndroid a ViewAndroid

This removes the need for tracking a parent view and a window
in each ViewAndroid. Instead the WindowAndroid is now just the root
View.
==========

to

==========
Make WindowAndroid a ViewAndroid

This removes the need for tracking a parent view and a window
in each ViewAndroid. Instead the WindowAndroid is now just the root
View.
==========

[commit-bot: I haz the power, 2016-07-21 17:04:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-21 17:05:49]

Description was changed from

==========
Make WindowAndroid a ViewAndroid

This removes the need for tracking a parent view and a window
in each ViewAndroid. Instead the WindowAndroid is now just the root
View.
==========

to

==========
Make WindowAndroid a ViewAndroid

This removes the need for tracking a parent view and a window
in each ViewAndroid. Instead the WindowAndroid is now just the root
View.

Committed: https://crrev.com/481b7fe028211025dc673949d4303cee6661e4ec
Cr-Commit-Position: refs/heads/master@{#406881}
==========

[commit-bot: I haz the power, 2016-07-21 17:05:50]

Patchset 4 (id:??) landed as
https://crrev.com/481b7fe028211025dc673949d4303cee6661e4ec
Cr-Commit-Position: refs/heads/master@{#406881}