Make WindowAndroid a ViewAndroid

ui/android/view_android.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/android/view_android.h"
 
 #include <algorithm>
 
 #include "base/android/jni_android.h"
 #include "cc/layers/layer.h"
 
 namespace ui {
 
 using base::android::AttachCurrentThread;
 using base::android::JavaRef;
 using base::android::ScopedJavaLocalRef;
 
-ViewAndroid::ViewAndroid(const JavaRef<jobject>& delegate,
-                         WindowAndroid* root_window)
-    : parent_(nullptr), window_(root_window), delegate_(delegate) {}
+ViewAndroid::ViewAndroid(const JavaRef<jobject>& delegate)
+    : parent_(nullptr), delegate_(delegate) {}
 
-ViewAndroid::ViewAndroid() : parent_(nullptr), window_(nullptr) {}
+ViewAndroid::ViewAndroid() : parent_(nullptr) {}
 
 ViewAndroid::~ViewAndroid() {
-  if (parent_)
-    parent_->RemoveChild(this);
+  RemoveFromParent();
 
   for (std::list<ViewAndroid*>::iterator it = children_.begin();
        it != children_.end(); it++) {
     DCHECK_EQ((*it)->parent_, this);
     (*it)->parent_ = nullptr;
   }
 }
 
 void ViewAndroid::AddChild(ViewAndroid* child) {
   DCHECK(child);
-  DCHECK(child->window_ == nullptr) << "Children shouldn't have a root window";
   DCHECK(std::find(children_.begin(), children_.end(), child) ==
          children_.end());
 
   children_.push_back(child);
   if (child->parent_)
-    parent_->RemoveChild(child);
+    child->RemoveFromParent();
   child->parent_ = this;
 }
 
+void ViewAndroid::RemoveFromParent() {
+  if (parent_)
+    parent_->RemoveChild(this);
+}
+
 void ViewAndroid::RemoveChild(ViewAndroid* child) {
   DCHECK(child);
   DCHECK_EQ(child->parent_, this);
 
   std::list<ViewAndroid*>::iterator it =
       std::find(children_.begin(), children_.end(), child);
   DCHECK(it != children_.end());
   children_.erase(it);
   child->parent_ = nullptr;
 }
 
-WindowAndroid* ViewAndroid::GetWindowAndroid() const {
-  if (window_)
-    return window_;
-
+WindowAndroid* ViewAndroid::GetWindowAndroid() {

[Yusuf, 2016/07/13 19:54:36]

GetWindowAndroid will always return null if this is the case, right?

When parent_ has no parent_, we should return the parent?

[no sievers, 2016/07/13 23:32:12]

It will return only non-null if the tree actually has a WindowAndroid at the
top. For that I overrode this method in WindowAndroid to return |this|.

   return parent_ ? parent_->GetWindowAndroid() : nullptr;
 }
 
-void ViewAndroid::SetWindowAndroid(WindowAndroid* root_window) {
-  window_ = root_window;
-  DCHECK(parent_ == nullptr) << "Children shouldn't have a root window";
-}
-
 const JavaRef<jobject>& ViewAndroid::GetViewAndroidDelegate()
     const {
   if (!delegate_.is_null())
     return delegate_;
 
   return parent_ ? parent_->GetViewAndroidDelegate() : delegate_;
 }
 
 cc::Layer* ViewAndroid::GetLayer() const {
   return layer_.get();
 }
 
 void ViewAndroid::SetLayer(scoped_refptr<cc::Layer> layer) {
   layer_ = layer;
 }
 
 }  // namespace ui