Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3716)

Unified Diff: blimp/engine/testing/Dockerfile

Issue 2136363002: Fill in testing Dockerfile stub. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment rewrite for directory creation. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/testing/Dockerfile
diff --git a/blimp/engine/testing/Dockerfile b/blimp/engine/testing/Dockerfile
index 711535347dce4aa52f8bb5e3a6fc7314a5f3f357..83aca2f31a91a9377237079ec84936ecb34d6fa0 100644
--- a/blimp/engine/testing/Dockerfile
+++ b/blimp/engine/testing/Dockerfile
@@ -1,2 +1,18 @@
-# Testing dockerfile stub
-# TODO(jessicag): Fill in (crbug.com/616945).
+# This Dockerfile is used to build a filesystem enviornment containing
Wez 2016/07/12 20:34:03 typo: environment
Jess 2016/07/12 21:40:25 Done.
+# binaries and required files for Blimp Engine test and tests for dependencies
+# of Blimp Engine. It is built on a base image (base:latest) that is also used
Wez 2016/07/12 20:34:03 nit: wording; suggest "... on the same base image
Jess 2016/07/12 21:40:25 Done.
+# for running the Engine itself.
+FROM base:latest
+
+RUN mkdir -p /out/test/
+
+# The glob below expands to all files, but does not add directories
+# recursively.
+# Test binaries assume src directory is 2 levels down. While this behavior can
+# be changed with flags, the directory stucture is set up to minimize
Wez 2016/07/12 20:34:03 typo: structure
Jess 2016/07/12 21:40:25 Done.
+# potential problems with initial integration.
Wez 2016/07/12 20:34:03 I think what you're saying here is "add all the fi
Jess 2016/07/12 21:40:25 There are data dependencies under the source tree
Wez 2016/07/13 00:43:41 Oh, interesting - so I suppose it would help in th
maniscalco 2016/07/13 15:03:23 Jess, correct me if I'm wrong, I believe they're g
Jess 2016/07/13 17:06:46 Nick's got it.
Wez 2016/07/13 18:32:05 OK, so the issue is that when we build the tarball
Jess 2016/07/13 19:51:13 Yes.
+ADD * /out/test/
+
+RUN chown -R blimp_user /out/test/
+
+USER blimp_user
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698