blimp/engine/testing/Dockerfile - Issue 2136363002: Fill in testing Dockerfile stub.

Side by Side Diff: blimp/engine/testing/Dockerfile

Issue 2136363002: Fill in testing Dockerfile stub. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment rewrite for directory creation. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Testing dockerfile stub	1 # This Dockerfile is used to build a filesystem enviornment containing
	Wez 2016/07/12 20:34:03 typo: environment typo: environment Jess 2016/07/12 21:40:25 Done. Show quoted text On 2016/07/12 20:34:03, Wez wrote: > typo: environment Done.
2 # TODO(jessicag): Fill in (crbug.com/616945).	2 # binaries and required files for Blimp Engine test and tests for dependencies

	3 # of Blimp Engine. It is built on a base image (base:latest) that is also used
	Wez 2016/07/12 20:34:03 nit: wording; suggest "... on the same base image nit: wording; suggest "... on the same base image that is used to run the Engine itself." Jess 2016/07/12 21:40:25 Done. Show quoted text On 2016/07/12 20:34:03, Wez wrote: > nit: wording; suggest "... on the same base image that is used to run the Engine > itself." Done.
	4 # for running the Engine itself.

	5 FROM base:latest

	6

	7 RUN mkdir -p /out/test/

	8

	9 # The glob below expands to all files, but does not add directories

	10 # recursively.

	11 # Test binaries assume src directory is 2 levels down. While this behavior can

	12 # be changed with flags, the directory stucture is set up to minimize
	Wez 2016/07/12 20:34:03 typo: structure typo: structure Jess 2016/07/12 21:40:25 Done. Show quoted text On 2016/07/12 20:34:03, Wez wrote: > typo: structure Done.
	13 # potential problems with initial integration.
	Wez 2016/07/12 20:34:03 I think what you're saying here is "add all the fi I think what you're saying here is "add all the files, without recursing into directories, and do so under a /two/part path to be consistent with test binaries' expectation of the build output path? My understanding was that with isolates, and now with GN, all test dependencies end up under the output directory - "knowing" that the directory two levels up was the source directory doesn't help unless we're also adding files from the source tree to the bundle, surely? Jess 2016/07/12 21:40:25 There are data dependencies under the source tree Show quoted text On 2016/07/12 20:34:03, Wez wrote: > I think what you're saying here is "add all the files, without recursing into > directories, and do so under a /two/part path to be consistent with test > binaries' expectation of the build output path? > > My understanding was that with isolates, and now with GN, all test dependencies > end up under the output directory - "knowing" that the directory two levels up > was the source directory doesn't help unless we're also adding files from the > source tree to the bundle, surely? There are data dependencies under the source tree that are added to the bundle, specifically ../../base/test/data/. Wez 2016/07/13 00:43:41 Oh, interesting - so I suppose it would help in th Show quoted text On 2016/07/12 21:40:25, Jess wrote: > On 2016/07/12 20:34:03, Wez wrote: > > I think what you're saying here is "add all the files, without recursing into > > directories, and do so under a /two/part path to be consistent with test > > binaries' expectation of the build output path? > > > > My understanding was that with isolates, and now with GN, all test > dependencies > > end up under the output directory - "knowing" that the directory two levels up > > was the source directory doesn't help unless we're also adding files from the > > source tree to the bundle, surely? > > There are data dependencies under the source tree that are added to the bundle, > specifically ../../base/test/data/. Oh, interesting - so I suppose it would help in this comment to be clear as to where those get added to the bundle, since it's not obvious at-a-glance. e.g. are they part of base:latest? maniscalco 2016/07/13 15:03:23 Jess, correct me if I'm wrong, I believe they're g Show quoted text On 2016/07/13 00:43:41, Wez wrote: > On 2016/07/12 21:40:25, Jess wrote: > > On 2016/07/12 20:34:03, Wez wrote: > > > I think what you're saying here is "add all the files, without recursing > into > > > directories, and do so under a /two/part path to be consistent with test > > > binaries' expectation of the build output path? > > > > > > My understanding was that with isolates, and now with GN, all test > > dependencies > > > end up under the output directory - "knowing" that the directory two levels > up > > > was the source directory doesn't help unless we're also adding files from > the > > > source tree to the bundle, surely? > > > > There are data dependencies under the source tree that are added to the > bundle, > > specifically ../../base/test/data/. > > Oh, interesting - so I suppose it would help in this comment to be clear as to > where those get added to the bundle, since it's not obvious at-a-glance. e.g. > are they part of base:latest? Jess, correct me if I'm wrong, I believe they're getting pulled in to the tarball that's fed to "docker build" because the dependencies are are properly expressed via GN. Jess 2016/07/13 17:06:46 Nick's got it. Show quoted text On 2016/07/13 15:03:23, maniscalco wrote: > On 2016/07/13 00:43:41, Wez wrote: > > On 2016/07/12 21:40:25, Jess wrote: > > > On 2016/07/12 20:34:03, Wez wrote: > > > > I think what you're saying here is "add all the files, without recursing > > into > > > > directories, and do so under a /two/part path to be consistent with test > > > > binaries' expectation of the build output path? > > > > > > > > My understanding was that with isolates, and now with GN, all test > > > dependencies > > > > end up under the output directory - "knowing" that the directory two > levels > > up > > > > was the source directory doesn't help unless we're also adding files from > > the > > > > source tree to the bundle, surely? > > > > > > There are data dependencies under the source tree that are added to the > > bundle, > > > specifically ../../base/test/data/. > > > > Oh, interesting - so I suppose it would help in this comment to be clear as to > > where those get added to the bundle, since it's not obvious at-a-glance. e.g. > > are they part of base:latest? > > Jess, correct me if I'm wrong, I believe they're getting pulled in to the > tarball that's fed to "docker build" because the dependencies are are properly > expressed via GN. Nick's got it. Wez 2016/07/13 18:32:05 OK, so the issue is that when we build the tarball Show quoted text On 2016/07/13 17:06:46, Jess wrote: > On 2016/07/13 15:03:23, maniscalco wrote: > > On 2016/07/13 00:43:41, Wez wrote: > > > On 2016/07/12 21:40:25, Jess wrote: > > > > On 2016/07/12 20:34:03, Wez wrote: > > > > > I think what you're saying here is "add all the files, without recursing > > > into > > > > > directories, and do so under a /two/part path to be consistent with test > > > > > binaries' expectation of the build output path? > > > > > > > > > > My understanding was that with isolates, and now with GN, all test > > > > dependencies > > > > > end up under the output directory - "knowing" that the directory two > > levels > > > up > > > > > was the source directory doesn't help unless we're also adding files > from > > > the > > > > > source tree to the bundle, surely? > > > > > > > > There are data dependencies under the source tree that are added to the > > > bundle, > > > > specifically ../../base/test/data/. > > > > > > Oh, interesting - so I suppose it would help in this comment to be clear as > to > > > where those get added to the bundle, since it's not obvious at-a-glance. > e.g. > > > are they part of base:latest? > > > > Jess, correct me if I'm wrong, I believe they're getting pulled in to the > > tarball that's fed to "docker build" because the dependencies are are properly > > expressed via GN. > > Nick's got it. OK, so the issue is that when we build the tarball for the bundle, we include test-data files _with their full source-directory-relative paths_, then? Jess 2016/07/13 19:51:13 Yes. Show quoted text On 2016/07/13 18:32:05, Wez wrote: > On 2016/07/13 17:06:46, Jess wrote: > > On 2016/07/13 15:03:23, maniscalco wrote: > > > On 2016/07/13 00:43:41, Wez wrote: > > > > On 2016/07/12 21:40:25, Jess wrote: > > > > > On 2016/07/12 20:34:03, Wez wrote: > > > > > > I think what you're saying here is "add all the files, without > recursing > > > > into > > > > > > directories, and do so under a /two/part path to be consistent with > test > > > > > > binaries' expectation of the build output path? > > > > > > > > > > > > My understanding was that with isolates, and now with GN, all test > > > > > dependencies > > > > > > end up under the output directory - "knowing" that the directory two > > > levels > > > > up > > > > > > was the source directory doesn't help unless we're also adding files > > from > > > > the > > > > > > source tree to the bundle, surely? > > > > > > > > > > There are data dependencies under the source tree that are added to the > > > > bundle, > > > > > specifically ../../base/test/data/. > > > > > > > > Oh, interesting - so I suppose it would help in this comment to be clear > as > > to > > > > where those get added to the bundle, since it's not obvious at-a-glance. > > e.g. > > > > are they part of base:latest? > > > > > > Jess, correct me if I'm wrong, I believe they're getting pulled in to the > > > tarball that's fed to "docker build" because the dependencies are are > properly > > > expressed via GN. > > > > Nick's got it. > > OK, so the issue is that when we build the tarball for the bundle, we include > test-data files _with their full source-directory-relative paths_, then? Yes.
	14 ADD * /out/test/

	15

	16 RUN chown -R blimp_user /out/test/

	17

	18 USER blimp_user

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »