Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3500)

Unified Diff: blimp/engine/testing/Dockerfile

Issue 2136363002: Fill in testing Dockerfile stub. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/testing/Dockerfile
diff --git a/blimp/engine/testing/Dockerfile b/blimp/engine/testing/Dockerfile
index 711535347dce4aa52f8bb5e3a6fc7314a5f3f357..3575c4eab90e606ce15cb7b93e361bebcb46023a 100644
--- a/blimp/engine/testing/Dockerfile
+++ b/blimp/engine/testing/Dockerfile
@@ -1,2 +1,12 @@
-# Testing dockerfile stub
-# TODO(jessicag): Fill in (crbug.com/616945).
+# Testing filesystem setup. Built from share setup with engine Dockerfile.
maniscalco 2016/07/11 22:55:24 I'm having a hard time parsing this comment. Can
Jess 2016/07/11 23:15:33 Updated comment. I am avoiding saying it builds a
+FROM base:latest
+
+RUN mkdir -p /out/test/
maniscalco 2016/07/11 22:55:24 What's the thinking behind the directory structure
Jess 2016/07/11 23:15:33 The test binaries by default assume src is down tw
maniscalco 2016/07/11 23:21:17 Ah, I see. OK, I suggest adding a comment here to
+
+# The glob below expands to all files, but does not add directories
+# recursively.
+ADD * /out/test/
+
+RUN chown -R blimp_user /out/test/
+
+USER blimp_user
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698