blimp/engine/testing/Dockerfile - Issue 2136363002: Fill in testing Dockerfile stub.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/engine/testing/Dockerfile

Issue 2136363002: Fill in testing Dockerfile stub. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Testing dockerfile stub	1 # Testing filesystem setup. Built from share setup with engine Dockerfile.
	maniscalco 2016/07/11 22:55:24 I'm having a hard time parsing this comment. Can I'm having a hard time parsing this comment. Can you reword? Maybe something like: "This Dockerfile is used to build an image containing Blimp Engine test and tests for dependencies of Blimp Engine. It is built on a base image (base:latest) that's also used for running the Engine itself." Jess 2016/07/11 23:15:33 Updated comment. I am avoiding saying it builds a Show quoted text On 2016/07/11 22:55:24, maniscalco wrote: > I'm having a hard time parsing this comment. Can you reword? Maybe something > like: > > "This Dockerfile is used to build an image containing Blimp Engine test and > tests for dependencies of Blimp Engine. It is built on a base image > (base:latest) that's also used for running the Engine itself." Updated comment. I am avoiding saying it builds an image because that isn't actually what is used to run tests. It is a service detail, but one that informs what should be included in this Dockerfile.
2 # TODO(jessicag): Fill in (crbug.com/616945).	2 FROM base:latest

	3

	4 RUN mkdir -p /out/test/
	maniscalco 2016/07/11 22:55:24 What's the thinking behind the directory structure What's the thinking behind the directory structure? Do you anticipate having other subdirs under /out? Would /test be simpler? Jess 2016/07/11 23:15:33 The test binaries by default assume src is down tw Show quoted text On 2016/07/11 22:55:24, maniscalco wrote: > What's the thinking behind the directory structure? Do you anticipate having > other subdirs under /out? Would /test be simpler? The test binaries by default assume src is down two directories. Something that can be easily handled by flags in the service, but I wanted to cut down on the gotchas while hooking everything together. maniscalco 2016/07/11 23:21:17 Ah, I see. OK, I suggest adding a comment here to Show quoted text On 2016/07/11 23:15:33, Jess wrote: > On 2016/07/11 22:55:24, maniscalco wrote: > > What's the thinking behind the directory structure? Do you anticipate having > > other subdirs under /out? Would /test be simpler? > > The test binaries by default assume src is down two directories. Something that > can be easily handled by flags in the service, but I wanted to cut down on the > gotchas while hooking everything together. Ah, I see. OK, I suggest adding a comment here to that effect. That ways it's clear that this isn't an arbitrary directory structure.
	5

	6 # The glob below expands to all files, but does not add directories

	7 # recursively.

	8 ADD * /out/test/

	9

	10 RUN chown -R blimp_user /out/test/

	11

	12 USER blimp_user

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »