Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 2136353003: NTP: fix bad layout when navigating back from a page with a theme-color. (Closed)

Created:
4 years, 5 months ago by Michael van Ouwerkerk
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP: fix bad layout when navigating back from a page with a theme-color. When navigating back from a page with a theme-color, more measuring and layout work is done with different values for the viewport height. Avoid storing anything in the layout params based on these changing values, as this would cause subsequent layout passes to be incorrect. Manual test page: http://mvano.github.io/sandbox/themecolor.html BUG=617109 Committed: https://crrev.com/975cd680f7ae920afb84cd8ca03ff3d96cfe39a2 Cr-Commit-Position: refs/heads/master@{#404858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -22 lines) Patch
M chrome/android/java/res/layout/new_tab_page_layout.xml View 5 chunks +7 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java View 7 chunks +27 lines, -17 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 5 months ago (2016-07-12 17:03:08 UTC) #2
Bernhard Bauer
LGTM, good catch!
4 years, 5 months ago (2016-07-12 17:09:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136353003/1
4 years, 5 months ago (2016-07-12 17:11:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261262)
4 years, 5 months ago (2016-07-12 20:30:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136353003/1
4 years, 5 months ago (2016-07-12 20:43:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 23:36:53 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 23:38:11 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 23:38:56 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/975cd680f7ae920afb84cd8ca03ff3d96cfe39a2
Cr-Commit-Position: refs/heads/master@{#404858}

Powered by Google App Engine
This is Rietveld 408576698