Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2163)

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_layout.xml

Issue 2136353003: NTP: fix bad layout when navigating back from a page with a theme-color. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 <org.chromium.chrome.browser.ntp.NewTabPageLayout 5 <org.chromium.chrome.browser.ntp.NewTabPageLayout
6 xmlns:android="http://schemas.android.com/apk/res/android" 6 xmlns:android="http://schemas.android.com/apk/res/android"
7 xmlns:chrome="http://schemas.android.com/apk/res-auto" 7 xmlns:chrome="http://schemas.android.com/apk/res-auto"
8 android:id="@+id/ntp_content" 8 android:id="@+id/ntp_content"
9 android:layout_width="match_parent" 9 android:layout_width="match_parent"
10 android:layout_height="match_parent" 10 android:layout_height="match_parent"
11 android:layout_gravity="center_horizontal" 11 android:layout_gravity="center_horizontal"
12 android:orientation="vertical" 12 android:orientation="vertical"
13 android:gravity="center" 13 android:gravity="center"
14 android:paddingTop="@dimen/toolbar_height_no_shadow" 14 android:paddingTop="@dimen/toolbar_height_no_shadow"
15 android:visibility="gone" > 15 android:visibility="gone" >
16 16
17 <!-- Spacer. Note: this must have layout_weight="1" and the other spacers mu st have 17 <!-- Top spacer. Note: the top spacer must have layout_weight="1" and the mi ddle and bottom
18 layout_weight="0". The NewTabPageLayout will redistribute the extra spa ce between 18 spacers must have layout_weight="0". The NewTabPageLayout will redistri bute the extra space
19 them. --> 19 between them. -->
20 <View 20 <View
21 android:id="@+id/ntp_top_spacer" 21 android:id="@+id/ntp_top_spacer"
22 android:layout_width="0dp" 22 android:layout_width="0dp"
23 android:layout_height="0dp" 23 android:layout_height="0dp"
24 android:layout_weight="1" 24 android:layout_weight="1"
25 android:visibility="invisible" /> 25 android:visibility="invisible" />
26 26
27 <!-- Search provider logo --> 27 <!-- Search provider logo -->
28 <org.chromium.chrome.browser.ntp.LogoView 28 <org.chromium.chrome.browser.ntp.LogoView
29 android:id="@+id/search_provider_logo" 29 android:id="@+id/search_provider_logo"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 <org.chromium.chrome.browser.widget.TintedImageView 63 <org.chromium.chrome.browser.widget.TintedImageView
64 android:id="@+id/voice_search_button" 64 android:id="@+id/voice_search_button"
65 android:layout_width="wrap_content" 65 android:layout_width="wrap_content"
66 android:layout_height="wrap_content" 66 android:layout_height="wrap_content"
67 android:layout_marginStart="12dp" 67 android:layout_marginStart="12dp"
68 android:layout_marginEnd="12dp" 68 android:layout_marginEnd="12dp"
69 android:contentDescription="@string/accessibility_toolbar_btn_mic" 69 android:contentDescription="@string/accessibility_toolbar_btn_mic"
70 android:src="@drawable/btn_mic" /> 70 android:src="@drawable/btn_mic" />
71 </LinearLayout> 71 </LinearLayout>
72 72
73 <!-- Spacer --> 73 <!-- Middle spacer -->
74 <View 74 <View
75 android:id="@+id/ntp_middle_spacer" 75 android:id="@+id/ntp_middle_spacer"
76 android:layout_width="0dp" 76 android:layout_width="0dp"
77 android:layout_height="0dp" 77 android:layout_height="0dp"
78 android:layout_weight="0" 78 android:layout_weight="0"
79 android:visibility="invisible" /> 79 android:visibility="invisible" />
80 80
81 <!-- Most visited items --> 81 <!-- Most visited items -->
82 <org.chromium.chrome.browser.ntp.MostVisitedLayout 82 <org.chromium.chrome.browser.ntp.MostVisitedLayout
83 android:id="@+id/most_visited_layout" 83 android:id="@+id/most_visited_layout"
84 android:layout_width="wrap_content" 84 android:layout_width="wrap_content"
85 android:layout_height="wrap_content" 85 android:layout_height="wrap_content"
86 android:layout_marginBottom="16dp" 86 android:layout_marginBottom="16dp"
87 android:layout_marginStart="12dp" 87 android:layout_marginStart="12dp"
88 android:layout_marginEnd="12dp" 88 android:layout_marginEnd="12dp"
89 android:layout_gravity="center_horizontal" 89 android:layout_gravity="center_horizontal"
90 android:paddingTop="@dimen/most_visited_layout_padding_top" 90 android:paddingTop="@dimen/most_visited_layout_padding_top"
91 android:paddingBottom="4dp" /> 91 android:paddingBottom="4dp" />
92 92
93 <!-- Most visited items placeholder --> 93 <!-- Most visited items placeholder -->
94 <ViewStub 94 <ViewStub
95 android:id="@+id/most_visited_placeholder_stub" 95 android:id="@+id/most_visited_placeholder_stub"
96 android:layout_width="match_parent" 96 android:layout_width="match_parent"
97 android:layout_height="wrap_content" 97 android:layout_height="wrap_content"
98 android:layout_weight="1" 98 android:layout_weight="1"
99 android:inflatedId="@+id/most_visited_placeholder" 99 android:inflatedId="@+id/most_visited_placeholder"
100 android:layout="@layout/most_visited_placeholder" /> 100 android:layout="@layout/most_visited_placeholder" />
101 101
102 <!-- Spacer --> 102 <!-- Bottom spacer -->
103 <View 103 <View
104 android:id="@+id/ntp_bottom_spacer" 104 android:id="@+id/ntp_bottom_spacer"
105 android:layout_width="0dp" 105 android:layout_width="0dp"
106 android:layout_height="0dp" 106 android:layout_height="0dp"
107 android:layout_weight="0" 107 android:layout_weight="0"
108 android:visibility="invisible" /> 108 android:visibility="invisible" />
109 109
110 <!-- Logo spacer -->
110 <View 111 <View
111 android:id="@+id/no_search_logo_spacer" 112 android:id="@+id/no_search_logo_spacer"
112 android:layout_width="match_parent" 113 android:layout_width="match_parent"
113 android:layout_height="0dp" 114 android:layout_height="0dp"
114 android:layout_weight="1" 115 android:layout_weight="1"
115 android:visibility="gone" /> 116 android:visibility="gone" />
116 117
118 <!-- Scroll spacer -->
117 <View 119 <View
118 android:id="@+id/ntp_scroll_spacer" 120 android:id="@+id/ntp_scroll_spacer"
119 android:layout_width="match_parent" 121 android:layout_width="match_parent"
120 android:layout_height="0dp" 122 android:layout_height="0dp"
121 android:visibility="gone" /> 123 android:visibility="gone" />
122 </org.chromium.chrome.browser.ntp.NewTabPageLayout> 124 </org.chromium.chrome.browser.ntp.NewTabPageLayout>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698