Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2136353002: Stop reading svn buildspec (Closed)

Created:
4 years, 5 months ago by dimu
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop reading svn buildspec Reviewed at https://codereview.chromium.org/2136143002/ BUG= Committed: https://crrev.com/08c596825aa5530f6364e59ecff7a8ac1323f9b8 Cr-Commit-Position: refs/heads/master@{#404742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M tools/bisect-builds.py View 2 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dimu
Committed patchset #1 (id:1) to pending queue manually as 4fe810ea1e13cbd46eb85f96ed021b067ac317a5.
4 years, 5 months ago (2016-07-11 23:06:39 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/08c596825aa5530f6364e59ecff7a8ac1323f9b8 Cr-Commit-Position: refs/heads/master@{#404742}
4 years, 5 months ago (2016-07-11 23:08:07 UTC) #3
pdr.
Why no reviewer? :( This introduced a syntax error, fix at https://codereview.chromium.org/2144733003
4 years, 5 months ago (2016-07-12 21:43:49 UTC) #5
dimu
4 years, 5 months ago (2016-07-12 21:59:56 UTC) #6
Message was sent while issue was closed. 
On 2016/07/12 21:43:49, pdr. wrote:
> Why no reviewer? :(
> 
> This introduced a syntax error, fix at
> https://codereview.chromium.org/2144733003

Sorry abt the confusions. 

I thought it's already fixed in https://codereview.chromium.org/2146583002/, 
but looks like the fix is not landed yet.

The original CL was uploaded mistakenly as I had some authentication issues 
committing to src.git, I created several CLs to reproduce the problem to try 
with google@ and chromium@ acct and other things... but it turned out I landed
an unreviewed CL.

The real reviewed CL is
https://codereview.chromium.org/2136143002/patch/20001/30001

Powered by Google App Engine
This is Rietveld 408576698