Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2144733003: Fix extra bracket syntax error in bisect-builds.py (Closed)

Created:
4 years, 5 months ago by pdr.
Modified:
4 years, 5 months ago
Reviewers:
dimu1, chrishtr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix extra bracket syntax error in bisect-builds.py [1] introduced the following syntax error: $ ./tools/bisect-builds.py --archive=mac64 -g 349700 -b 370248 File "./tools/bisect-builds.py", line 897 return m.group(1)] ^ Simple fix to just remove the extra bracket. I'm not a python expert so hopefully this is the most pythonic approach to bracket removal. [1] https://crrev.com/08c596825aa5530f6364e59ecff7a8ac1323f9b8 NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/bisect-builds.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
pdr.
4 years, 5 months ago (2016-07-12 21:42:25 UTC) #2
pdr.
4 years, 5 months ago (2016-07-13 16:39:42 UTC) #5
chrishtr
lgtm
4 years, 5 months ago (2016-07-13 16:57:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144733003/1
4 years, 5 months ago (2016-07-13 16:58:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/217321)
4 years, 5 months ago (2016-07-13 17:08:21 UTC) #10
pdr.
4 years, 5 months ago (2016-07-13 17:33:12 UTC) #11
On 2016/07/13 at 17:08:21, commit-bot wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Looks like fmalita beat me to it:
https://chromium.googlesource.com/chromium/src/+/a898d221e7a213f2b011c1751276...

Powered by Google App Engine
This is Rietveld 408576698