Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2136343002: Revert of try to speed-up maprect + round2i + contains (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of try to speed-up maprect + round2i + contains (patchset #8 id:140001 of https://codereview.chromium.org/2133413002/ ) Reason for revert: Breaking the roll... https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/253294/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > try to speed-up maprect + round2i + contains > > We call roundOut in a few places. If we can get SkNx::Ceil we could efficiently implement that as well. > > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2133413002 > CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/b42b785d1cbc98bd34aceae338060831b974f9c5 TBR=mtklein@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/afb8539f62b3e92dcc5dbe0598605f4058a1e03a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1139 lines, -1284 lines) Patch
M bench/RectBench.cpp View 1 chunk +0 lines, -90 lines 0 comments Download
M gyp/core.gypi View 2 chunks +1 line, -1 line 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkRect.h View 2 chunks +1 line, -23 lines 0 comments Download
D include/private/SkNx.h View 1 chunk +0 lines, -310 lines 0 comments Download
D include/private/SkNx_neon.h View 1 chunk +0 lines, -453 lines 0 comments Download
D include/private/SkNx_sse.h View 1 chunk +0 lines, -374 lines 0 comments Download
A src/core/SkNx.h View 1 chunk +310 lines, -0 lines 0 comments Download
A src/opts/SkNx_neon.h View 1 chunk +453 lines, -0 lines 0 comments Download
A src/opts/SkNx_sse.h View 1 chunk +374 lines, -0 lines 0 comments Download
M tests/RectTest.cpp View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
msarett
Created Revert of try to speed-up maprect + round2i + contains
4 years, 5 months ago (2016-07-11 21:56:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136343002/1
4 years, 5 months ago (2016-07-11 21:56:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/afb8539f62b3e92dcc5dbe0598605f4058a1e03a
4 years, 5 months ago (2016-07-11 21:57:29 UTC) #5
reed1
4 years, 5 months ago (2016-07-11 22:09:35 UTC) #6
Message was sent while issue was closed.
SkNx_sse.h

e:\b\build\slave\win\build\src\third_party\skia\include\private\sknx_sse.h(285):
error C2220: warning treated as error - no 'object' file generated

        auto flip = _mm_set1_epi8(char(0x80));

e:\b\build\slave\win\build\src\third_party\skia\include\private\sknx_sse.h(285):
warning C4310: cast truncates constant value
e:\b\build\slave\win\build\src\third_party\skia\include\private\sknx_sse.h(321):
warning C4310: cast truncates constant value

    return _mm_add_epi16(_mm_packs_epi32(_32, _32),
_mm_set1_epi16((short)0x8000));

Powered by Google App Engine
This is Rietveld 408576698