Fix --use-mus-in-renderer for mus+ash

Fix --use-mus-in-renderer for mus+ash

BUG=626390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/168910acde5c5eb79f595ef274cb53cf37915df4
Cr-Commit-Position: refs/heads/master@{#405470}

[Peng, 2016-07-11 21:14:40]

Description was changed from

==========
MusInRenderer doesn't work

BUG=
==========

to

==========
MusInRenderer doesn't work

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Peng, 2016-07-12 12:07:50]

Description was changed from

==========
MusInRenderer doesn't work

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Fix --use-mus-in-renderer for mus+ash

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Peng, 2016-07-13 14:42:20]

Description was changed from

==========
Fix --use-mus-in-renderer for mus+ash

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Fix --use-mus-in-renderer for mus+ash

BUG=626390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Peng, 2016-07-13 14:42:49]

penghuang@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Peng, 2016-07-13 14:42:50]

Hi Fady, PTAL. Thanks.

[Fady Samuel, 2016-07-13 14:48:47]

I'm not the best person to review these changes. I'd get rockot@ and piman@ to
confirm correctness. I also think it's worthwhile to file a bug to write a
regression test for --use-mus-in-renderer.

https://codereview.chromium.org/2136313002/diff/140001/cc/ipc/render_pass_str...
File cc/ipc/render_pass_struct_traits.cc (left):

https://codereview.chromium.org/2136313002/diff/140001/cc/ipc/render_pass_str...
cc/ipc/render_pass_struct_traits.cc:15: DCHECK_GT(input->quad_list.size(), 0u);
A question for piman@: Are empty quad lists considered valid? If so, then these
DCHECKs can be removed. Otherwise something is wrong.

https://codereview.chromium.org/2136313002/diff/140001/cc/ipc/render_pass_str...
cc/ipc/render_pass_struct_traits.cc:28:
DCHECK_EQ(input->shared_quad_state_list.size() - 1, sqs_iter.index());
I'd like to preserve this DCHECK if shared_quad_state_list.size() > 0

Maybe DCHECK(shared_quad_state_list.size() == 0 ||
(input->shared_quad_state_list.size() - 1, sqs_iter.index()));

https://codereview.chromium.org/2136313002/diff/140001/content/renderer/mus/r...
File content/renderer/mus/render_widget_window_tree_client_factory.cc (right):

https://codereview.chromium.org/2136313002/diff/140001/content/renderer/mus/r...
content/renderer/mus/render_widget_window_tree_client_factory.cc:36:
DCHECK(ChildThread::Get()->GetMojoShellConnection());
I'd get rockot@ to review these changes.

[Peng, 2016-07-13 15:01:12]

penghuang@chromium.org changed reviewers:
+ piman@chromium.org, rockot@chromium.org

[Peng, 2016-07-13 15:01:13]

+piman for content and the *_struct_traits
+rockot for MojoShellConnection related changed.

Hi Antoine & Ken, PTAL. Thanks.

https://codereview.chromium.org/2136313002/diff/140001/cc/ipc/render_pass_str...
File cc/ipc/render_pass_struct_traits.cc (left):

https://codereview.chromium.org/2136313002/diff/140001/cc/ipc/render_pass_str...
cc/ipc/render_pass_struct_traits.cc:15: DCHECK_GT(input->quad_list.size(), 0u);
On 2016/07/13 14:48:47, Fady Samuel wrote:
> A question for piman@: Are empty quad lists considered valid? If so, then
these
> DCHECKs can be removed. Otherwise something is wrong.

Sure. I will ask piman@ review this CL too.

https://codereview.chromium.org/2136313002/diff/140001/cc/ipc/render_pass_str...
cc/ipc/render_pass_struct_traits.cc:28:
DCHECK_EQ(input->shared_quad_state_list.size() - 1, sqs_iter.index());
On 2016/07/13 14:48:47, Fady Samuel wrote:
> I'd like to preserve this DCHECK if shared_quad_state_list.size() > 0
> 
> Maybe DCHECK(shared_quad_state_list.size() == 0 ||
> (input->shared_quad_state_list.size() - 1, sqs_iter.index()));

Done.

https://codereview.chromium.org/2136313002/diff/140001/content/renderer/mus/r...
File content/renderer/mus/render_widget_window_tree_client_factory.cc (right):

https://codereview.chromium.org/2136313002/diff/140001/content/renderer/mus/r...
content/renderer/mus/render_widget_window_tree_client_factory.cc:36:
DCHECK(ChildThread::Get()->GetMojoShellConnection());
On 2016/07/13 14:48:47, Fady Samuel wrote:
> I'd get rockot@ to review these changes.

Sure.

[Ken Rockot(use gerrit already), 2016-07-13 18:29:02]

content/renderer changes lgtm as non owner

https://codereview.chromium.org/2136313002/diff/160001/content/renderer/mus/r...
File content/renderer/mus/render_widget_mus_connection.cc (right):

https://codereview.chromium.org/2136313002/diff/160001/content/renderer/mus/r...
content/renderer/mus/render_widget_mus_connection.cc:49: auto* connector =
nit: why add the local?

[piman, 2016-07-13 18:58:25]

lgtm

[Peng, 2016-07-13 19:00:21]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[Peng, 2016-07-13 19:00:36]

https://codereview.chromium.org/2136313002/diff/160001/content/renderer/mus/r...
File content/renderer/mus/render_widget_mus_connection.cc (right):

https://codereview.chromium.org/2136313002/diff/160001/content/renderer/mus/r...
content/renderer/mus/render_widget_mus_connection.cc:49: auto* connector =
On 2016/07/13 18:29:02, Ken Rockot wrote:
> nit: why add the local?

Just copy those two lines from somewhere else, so ...

Changed it back.

[Peng, 2016-07-13 19:02:25]

penghuang@chromium.org changed reviewers:
+ dcheng@chromium.org

[Peng, 2016-07-13 19:02:25]

+dcheng for cc/ipc/render_pass_struct_traits.cc

Hi Daniel, PTAL. Thanks.

[commit-bot: I haz the power, 2016-07-13 19:02:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:12:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 19:12:38]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)

[Peng, 2016-07-13 19:19:08]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 19:20:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:33:41]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names without "master." prefix is deprecated:
tryserver.blink. For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-13 20:25:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 20:25:58]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-07-14 03:22:50]

struct traits lgtm

[Peng, 2016-07-14 11:05:58]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2016-07-14 11:05:58]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2136313002/#ps200001
(title: "Fix build error.")

[commit-bot: I haz the power, 2016-07-14 11:06:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 11:22:08]

Description was changed from

==========
Fix --use-mus-in-renderer for mus+ash

BUG=626390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Fix --use-mus-in-renderer for mus+ash

BUG=626390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-14 11:22:09]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-07-14 11:22:11]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 11:24:41]

Description was changed from

==========
Fix --use-mus-in-renderer for mus+ash

BUG=626390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Fix --use-mus-in-renderer for mus+ash

BUG=626390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/168910acde5c5eb79f595ef274cb53cf37915df4
Cr-Commit-Position: refs/heads/master@{#405470}
==========

[commit-bot: I haz the power, 2016-07-14 11:24:43]

Patchset 11 (id:??) landed as
https://crrev.com/168910acde5c5eb79f595ef274cb53cf37915df4
Cr-Commit-Position: refs/heads/master@{#405470}