Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/select/main.js

Issue 2136193002: Fix crash on clicking on <select> tag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add browser test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/platform_apps/web_view/select/main.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/focus_accessibility/main.js b/chrome/test/data/extensions/platform_apps/web_view/select/main.js
similarity index 53%
copy from chrome/test/data/extensions/platform_apps/web_view/focus_accessibility/main.js
copy to chrome/test/data/extensions/platform_apps/web_view/select/main.js
index 9fe2ee1957629b6bd638ab83693340f65d9b3cfa..af60c694b9edacb8480175a001e4ec50696d0cd1 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/focus_accessibility/main.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/select/main.js
@@ -2,13 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-function CreateWebViewAndGuest(callback) {
+function CreateWebViewAndGuest() {
var webview = document.createElement('webview');
+ webview.allowtransparency = true;
+ webview.allowscaling = true;
var onLoadStop = function(e) {
chrome.test.sendMessage('WebViewTest.LAUNCHED');
webview.removeEventListener('loadstop', onLoadStop);
webview.removeEventListener('loadabort', onLoadAbort);
- callback();
};
webview.addEventListener('loadstop', onLoadStop);
@@ -17,25 +18,31 @@ function CreateWebViewAndGuest(callback) {
webview.removeEventListener('loadstop', onLoadStop);
webview.removeEventListener('loadabort', onLoadAbort);
};
- webview.src = 'data:text/html,' +
- '<html><body><button>Guest button</button></body></html>';
+
+ webview.src = 'data:text/html,<!DOCTYPE html>\n' +
+ '<style>\n' +
+ 'select {\n' +
+ ' position: absolute;\n' +
+ ' top: 9px;\n' +
+ ' left: 9px;\n' +
+ ' height: 25px;\n' +
+ ' width: 80px;\n' +
+ '}\n' +
+ '</style>\n' +
+ '<html>\n' +
+ ' <body>\n' +
+ ' <select>\n' +
+ ' <option selected>Apple</option>\n' +
+ ' <option>Orange</option>\n' +
+ ' <option>Banana</option>\n' +
+ ' </select>\n' +
+ ' </body>\n' +
+ '</html>\n';
+
return webview;
}
onload = function() {
- var webview = CreateWebViewAndGuest(function() {
- webview.addEventListener('newwindow', function(e) {
- var newwebview = document.createElement('webview');
- newwebview.addEventListener('loadstop', function(e) {
- chrome.test.sendMessage('WebViewTest.NEWWINDOW');
- });
- e.window.attach(newwebview);
- document.body.appendChild(newwebview);
- });
-
- webview.addEventListener('loadstop', function(e) {
- chrome.test.sendMessage('WebViewTest.LOADSTOP');
- });
- });
+ var webview = CreateWebViewAndGuest();
document.body.appendChild(webview);
};

Powered by Google App Engine
This is Rietveld 408576698