Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2136193002: Fix crash on clicking on <select> tag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add browser test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/apps/guest_view/DEPS ('K') | « chrome/test/data/extensions/platform_apps/web_view/select/test.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index d03257601681455b5cd3e03f793aa8e381b3b189..61ff408ffa389344ea348e36c5a66a3b3dbd7398 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -2460,6 +2460,8 @@ void RenderWidgetHostViewAura::UpdateCursorIfOverSelf() {
}
ui::InputMethod* RenderWidgetHostViewAura::GetInputMethod() const {
+ if (!window_)
+ return NULL;
jochen (gone - plz use gerrit) 2016/07/14 15:01:51 nullptr please
khmel 2016/07/14 21:06:45 Done.
aura::Window* root_window = window_->GetRootWindow();
if (!root_window)
return NULL;
« chrome/browser/apps/guest_view/DEPS ('K') | « chrome/test/data/extensions/platform_apps/web_view/select/test.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698