Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 2136173003: Add an histogram to differentiate between hang types of the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed asan issue Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_delegate.h
diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h
index a72360c42728ceeb3eabb72701806cbb68b1ea6b..58b52847ef732891d33d01232529b7eeddd25762 100644
--- a/content/browser/renderer_host/render_widget_host_delegate.h
+++ b/content/browser/renderer_host/render_widget_host_delegate.h
@@ -133,9 +133,24 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {
virtual RenderWidgetHostImpl* GetFocusedRenderWidgetHost(
RenderWidgetHostImpl* receiving_widget);
+ // Used in histograms to differentiate between the different types of
+ // renderer hang reported by RenderWidgetHostDelegate::RendererUnresponsive.
+ // Only add values at the end, do not delete values.
+ enum RendererUnresponsiveType {
+ RENDERER_UNRESPONSIVE_UNKNOWN = 0,
+ RENDERER_UNRESPONSIVE_IN_FLIGHT_EVENTS = 1,
+ RENDERER_UNRESPONSIVE_DIALOG_CLOSED = 2,
+ RENDERER_UNRESPONSIVE_DIALOG_SUPPRESSED = 3,
+ RENDERER_UNRESPONSIVE_BEFORE_UNLOAD = 4,
+ RENDERER_UNRESPONSIVE_UNLOAD = 5,
+ RENDERER_UNRESPONSIVE_CLOSE_PAGE = 6,
+ RENDERER_UNRESPONSIVE_MAX = RENDERER_UNRESPONSIVE_CLOSE_PAGE,
+ };
+
// Notification that the renderer has become unresponsive. The
// delegate can use this notification to show a warning to the user.
- virtual void RendererUnresponsive(RenderWidgetHostImpl* render_widget_host) {}
+ virtual void RendererUnresponsive(RenderWidgetHostImpl* render_widget_host,
+ RendererUnresponsiveType type) {}
// Notification that a previously unresponsive renderer has become
// responsive again. The delegate can use this notification to end the
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698