content/browser/renderer_host/render_view_host_impl.cc - Issue 2136173003: Add an histogram to differentiate between hang types of the renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 2136173003: Add an histogram to differentiate between hang types of the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed asan issue Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 023cb5fafb7acd3f6a4bd7c3a4f25c2ed329eab0..6b4d5d530c3f912886cd0ee5214a00ebf2e253e1 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -575,7 +575,8 @@ WebPreferences RenderViewHostImpl::ComputeWebkitPrefs() {

void RenderViewHostImpl::ClosePage() {

is_waiting_for_close_ack_ = true;

GetWidget()->StartHangMonitorTimeout(

- TimeDelta::FromMilliseconds(kUnloadTimeoutMS));

+ TimeDelta::FromMilliseconds(kUnloadTimeoutMS),

+ RenderWidgetHostDelegate::RENDERER_UNRESPONSIVE_CLOSE_PAGE);

if (IsRenderViewLive()) {

// Since we are sending an IPC message to the renderer, increase the event