content/browser/frame_host/render_frame_host_manager_unittest.cc - Issue 2136173003: Add an histogram to differentiate between hang types of the renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 2136173003: Add an histogram to differentiate between hang types of the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed asan issue Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager_unittest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc

index 70cc16900a4da0d0f12e05f87adb2ea1ff983b00..5134c737f9d889f32e8caaf7aca67623d0b52de0 100644

--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc

@@ -1736,7 +1736,9 @@ TEST_F(RenderFrameHostManagerTest, CloseWithPendingWhileUnresponsive) {

EXPECT_TRUE(contents()->CrossProcessNavigationPending());

// Simulate the unresponsiveness timer. The tab should close.

- contents()->RendererUnresponsive(rfh1->render_view_host()->GetWidget());

+ contents()->RendererUnresponsive(

+ rfh1->render_view_host()->GetWidget(),

+ RenderWidgetHostDelegate::RENDERER_UNRESPONSIVE_CLOSE_PAGE);

EXPECT_TRUE(close_delegate.is_closed());

}

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »