Issue 2136173002: Make sure Shared Modules cannot be disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2136173002: Make sure Shared Modules cannot be disabled (Closed)

Created:
4 years, 5 months ago by elijahtaylor1

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Make sure Shared Modules cannot be disabled BUG=601310, 620091 TEST=ExtensionServiceTest.CannotDisableSharedModules TEST=manually disable shared module in preferences, start chrome and observe shared module is enabled on restart Review-Url: https://codereview.chromium.org/2131173003 Cr-Commit-Position: refs/heads/master@{#404554} (cherry picked from commit 49c09c5cdf77a9f8380ce78b0e450006e22110f6) Committed: https://chromium.googlesource.com/chromium/src/+/01925b7fc8a584580e564f8ad2c2f96a2e96441e

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
	M	chrome/browser/extensions/extension_service.cc	View		2 chunks	+18 lines, -0 lines	0 comments	Download
	M	chrome/browser/extensions/extension_service_unittest.cc	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

elijahtaylor1

4 years, 5 months ago (2016-07-11 19:35:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
01925b7fc8a584580e564f8ad2c2f96a2e96441e.