Make sure Shared Modules cannot be disabled

Make sure Shared Modules cannot be disabled

BUG=601310, 620091
TEST=ExtensionServiceTest.CannotDisableSharedModules
TEST=manually disable shared module in preferences, start chrome and observe
     shared module is enabled on restart

Committed: https://crrev.com/49c09c5cdf77a9f8380ce78b0e450006e22110f6
Cr-Commit-Position: refs/heads/master@{#404554}

[elijahtaylor1, 2016-07-08 21:14:20]

Description was changed from

==========
Make sure Shared Modules cannot be disabled

BUG=601310,620091
TEST=ExtensionServiceTest.CannotDisableSharedModules
TEST=manually disable shared module in preferences, start chrome and observe
     shared module is enabled on restart
==========

to

==========
Make sure Shared Modules cannot be disabled

BUG=601310,620091
TEST=ExtensionServiceTest.CannotDisableSharedModules
TEST=manually disable shared module in preferences, start chrome and observe
     shared module is enabled on restart
==========

[elijahtaylor1, 2016-07-08 21:14:20]

elijahtaylor@chromium.org changed reviewers:
+ asargent@chromium.org

[elijahtaylor1, 2016-07-08 21:15:16]

Hi Antony, I think I talked to you about this a few months ago.  PTAL, let me
know if you have any questions

[asargent_no_longer_on_chrome, 2016-07-08 23:26:12]

lgtm

https://codereview.chromium.org/2131173003/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/2131173003/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_service.cc:1429: // Enable any Shared
Modules that incorrectly got disabled previously.
Can we leave this in for something like 10 chrome releases, and then remove it?
If so, maybe amend comment to mention something like "ok to remove after chrome
64" or something

[elijahtaylor1, 2016-07-08 23:32:19]

On 2016/07/08 23:26:12, Antony Sargent wrote:
> lgtm
> 
>
https://codereview.chromium.org/2131173003/diff/1/chrome/browser/extensions/e...
> File chrome/browser/extensions/extension_service.cc (right):
> 
>
https://codereview.chromium.org/2131173003/diff/1/chrome/browser/extensions/e...
> chrome/browser/extensions/extension_service.cc:1429: // Enable any Shared
> Modules that incorrectly got disabled previously.
> Can we leave this in for something like 10 chrome releases, and then remove
it?
> If so, maybe amend comment to mention something like "ok to remove after
chrome
> 64" or something

yeah, I had thought about that, and it seems reasonable.  My only concern was
that something not of chrome might be mucking with things, but I guess there's
not much we can do about that outside of any other efforts to protect users from
tampering.

Done

[elijahtaylor1, 2016-07-08 23:32:44]

https://codereview.chromium.org/2131173003/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/2131173003/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_service.cc:1429: // Enable any Shared
Modules that incorrectly got disabled previously.
On 2016/07/08 23:26:12, Antony Sargent wrote:
> Can we leave this in for something like 10 chrome releases, and then remove
it?
> If so, maybe amend comment to mention something like "ok to remove after
chrome
> 64" or something
> 

Done.

[elijahtaylor1, 2016-07-08 23:32:55]

The CQ bit was checked by elijahtaylor@chromium.org

[elijahtaylor1, 2016-07-08 23:32:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2131173003/#ps20001
(title: "feedback")

[commit-bot: I haz the power, 2016-07-08 23:33:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 01:07:19]

Description was changed from

==========
Make sure Shared Modules cannot be disabled

BUG=601310,620091
TEST=ExtensionServiceTest.CannotDisableSharedModules
TEST=manually disable shared module in preferences, start chrome and observe
     shared module is enabled on restart
==========

to

==========
Make sure Shared Modules cannot be disabled

BUG=601310,620091
TEST=ExtensionServiceTest.CannotDisableSharedModules
TEST=manually disable shared module in preferences, start chrome and observe
     shared module is enabled on restart
==========

[commit-bot: I haz the power, 2016-07-09 01:07:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-09 01:07:24]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-09 01:09:49]

Description was changed from

==========
Make sure Shared Modules cannot be disabled

BUG=601310,620091
TEST=ExtensionServiceTest.CannotDisableSharedModules
TEST=manually disable shared module in preferences, start chrome and observe
     shared module is enabled on restart
==========

to

==========
Make sure Shared Modules cannot be disabled

BUG=601310,620091
TEST=ExtensionServiceTest.CannotDisableSharedModules
TEST=manually disable shared module in preferences, start chrome and observe
     shared module is enabled on restart

Committed: https://crrev.com/49c09c5cdf77a9f8380ce78b0e450006e22110f6
Cr-Commit-Position: refs/heads/master@{#404554}
==========

[commit-bot: I haz the power, 2016-07-09 01:09:50]

Patchset 2 (id:??) landed as
https://crrev.com/49c09c5cdf77a9f8380ce78b0e450006e22110f6
Cr-Commit-Position: refs/heads/master@{#404554}