third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html - Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display

Unified Diff: third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: simplify the test case Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

diff --git a/third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html b/third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

new file mode 100644

index 0000000000000000000000000000000000000000..e8041f80b3c26699f23556208f484aadcf456d1b

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

@@ -0,0 +1,17 @@

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<body>

+<div id="description">

yosin_UTC9 2016/07/13 06:44:10 I think we don't need to have "description" DIV.

+<span><p>test</p><p>On success, you will see a series of "<span class="pass">PASS</span>" messages, followed by "<span class="pass">TEST COMPLETE</span>".</p></span>

yosin_UTC9 2016/07/13 06:44:10 We might use random text such as "foo", "bar", "ab

+</div>

+</body>

+<script>

+test(function() {

+ // This test case was created by ClusterFuzz.

+ // See http://crbug.com/626991

+ document.designMode = 'on';

+ document.execCommand("selectAll");

+ document.execCommand("CreateLink", 0, "foo");

yosin_UTC9 2016/07/13 06:44:10 Can we use HTML after executing "createLink"? Also

joone 2016/07/13 07:31:50 What does it mean?

yosin_UTC9 2016/07/13 08:02:42 Since "createLink" isn't part of nullptr reference

+ document.execCommand("inserthtml", false, "<span id='green' style='color:green'>green</span>");

yosin_UTC9 2016/07/13 06:44:10 Let's use single-quote for JavaScript and double-q

+}, 'No crash');

+</script>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »