third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html - Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: simplify the test case Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <script src="../../resources/testharness.js"></script>

	2 <script src="../../resources/testharnessreport.js"></script>

	3 <body>

	4 <div id="description">
	yosin_UTC9 2016/07/13 06:44:10 I think we don't need to have "description" DIV. I think we don't need to have "description" DIV.
	5 <span><p>test</p><p>On success, you will see a series of "<span class="pass">PAS S</span>" messages, followed by "<span class="pass">TEST COMPLETE</span>".</p></ span>
	yosin_UTC9 2016/07/13 06:44:10 We might use random text such as "foo", "bar", "ab We might use random text such as "foo", "bar", "abc" etc to reduce length of text.
	6 </div>

	7 </body>

	8 <script>

	9 test(function() {

	10 // This test case was created by ClusterFuzz.

	11 // See http://crbug.com/626991

	12 document.designMode = 'on';

	13 document.execCommand("selectAll");

	14 document.execCommand("CreateLink", 0, "foo");
	yosin_UTC9 2016/07/13 06:44:10 Can we use HTML after executing "createLink"? Also Can we use HTML after executing "createLink"? Also, can we use assert_selection() to verify final state of selection? joone 2016/07/13 07:31:50 What does it mean? Show quoted text On 2016/07/13 06:44:10, Yosi_UTC9 wrote: > Can we use HTML after executing "createLink"? What does it mean? yosin_UTC9 2016/07/13 08:02:42 Since "createLink" isn't part of nullptr reference Show quoted text On 2016/07/13 at 07:31:50, joone wrote: > On 2016/07/13 06:44:10, Yosi_UTC9 wrote: > > Can we use HTML after executing "createLink"? > > What does it mean? Since "createLink" isn't part of nullptr reference. We can have a resulted HTML fragment of "createLink" command. I would like to have assert_selection( '...^...\|...', ['insertHTML', '<span id="green" style="color:green">green</span>'], '...^...\|...'); Note: Please read "..." as real HTML markup.
	15 document.execCommand("inserthtml", false, "<span id='green' style='color:green '>green</span>");
	yosin_UTC9 2016/07/13 06:44:10 Let's use single-quote for JavaScript and double-q Let's use single-quote for JavaScript and double-quote for HTML including embedded into JS.
	16 }, 'No crash');

	17 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »