third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html - Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use of the short form for running the insertHTML command Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

diff --git a/third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html b/third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

new file mode 100644

index 0000000000000000000000000000000000000000..8accab5780623e3beed7ead90f83fe122c731917

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

@@ -0,0 +1,13 @@

+<!doctype html>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../assert_selection.js"></script>

+<div id="log"></div>

+<script>

+test(() => {

+ assert_selection(

+ '<div contenteditable><span><a href="foo"><p>^test</p><p>foo<span>bar</span>foo<span>bar</span>.|</p></a></span></div>',

+ 'insertHTML <span>green</span>',

joone 2016/07/15 08:23:33 I removed the style attribute then it works. Anyw

yosin_UTC9 2016/07/15 08:26:14 Right. I'll improve assert_selection later. Thanks

+ '<div contenteditable><span><p><a href="foo">green|</a></p></span></div>');

+}, 'Replace the selected tags with span tags');

+</script>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »