third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html - Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use of the short form for running the insertHTML command Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../assert_selection.js"></script>

	5 <div id="log"></div>

	6 <script>

	7 test(() => {

	8 assert_selection(

	9 '<div contenteditable><span><a href="foo"><p>^test</p><p>foo<span>bar</span> foo<span>bar</span>.\|</p></a></span></div>',

	10 'insertHTML <span>green</span>',
	joone 2016/07/15 08:23:33 I removed the style attribute then it works. Anyw I removed the style attribute then it works. Anyway, we need to improve assert_selection function to handle attribute values. yosin_UTC9 2016/07/15 08:26:14 Right. I'll improve assert_selection later. Thanks Show quoted text On 2016/07/15 at 08:23:33, joone wrote: > I removed the style attribute then it works. > Anyway, we need to improve assert_selection function to handle attribute values. Right. I'll improve assert_selection later. Thanks for finding! Let's commit this patch.
	11 '<div contenteditable><span><p><a href="foo">green\|</a></p></span></div>');

	12 }, 'Replace the selected tags with span tags');

	13 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »