third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html - Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display

Unified Diff: third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove CreateLink command Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

diff --git a/third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html b/third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

new file mode 100644

index 0000000000000000000000000000000000000000..c5ee8e5f3ff2ff9d46b9e20f36ba1722c978dfcf

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

@@ -0,0 +1,15 @@

+<!doctype html>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../assert_selection.js"></script>

+<div id="log"></div>

+<script>

+test(() => {

+ assert_selection(

+ '<div contenteditable><span><a href=\"foo\"><p>^test</p><p>foo<span>bar</span>foo<span>bar</span>.|</p></a></span></div>',

yosin_UTC9 2016/07/15 02:19:00 nit: No need to escape double quote. This is the r

+ selection => {

yosin_UTC9 2016/07/15 02:19:00 nit: You can use short form: ['insertHTML', '<span

joone 2016/07/15 05:57:52 assert_selection( '<div contenteditable><span>

yosin_UTC9 2016/07/15 07:06:40 Oops, sorry for confusion. I said wrong thing. We

Oops, sorry for confusion. I said wrong thing. We could write: assert_selection( '<div contenteditable><span><a href="foo"><p>^test</p><p>foo<span>bar</span>foo<span>bar</span>.|</p></a></span></div>', 'insertHTML <span style="color:green">green</span>', '<div contenteditable><span><p><a href="foo"><span style="color:green">green|</span></a></p></span></div>'); Use space separated string instead of array. Here is an implementation of assert_selection: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/editing/a... function assertSelection( inputText, tester, expectedText, opt_description = '') { /** @type {string} */ const description = opt_description === '' ? assembleDescription() : opt_description; checkExpectedText(expectedText); const sample = new Sample(inputText); if (typeof(tester) === 'function') { tester.call(window, sample.selection); } else if (typeof(tester) === 'string') { const strings = tester.split(' '); sample.document.execCommand(strings[0], false, strings[1]); } else { throw new Error(`Invalid tester: ${tester}`); } It used be an array but it was changed to string to be shorter.

+ selection.document.execCommand('inserthtml', false, '<span style=\"color:green\">green</span>');

+ },

+ '<div contenteditable><span><p><a href=\"foo\"><span style=\"color:green\">green|</span></a></p></span></div>');

yosin_UTC9 2016/07/15 02:19:00 nit: No need to escape double quote. This is the r

+}, 'Replace the selected tags with span tags');

+</script>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »