third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html - Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display

Side by Side Diff: third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove CreateLink command Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../assert_selection.js"></script>

	5 <div id="log"></div>

	6 <script>

	7 test(() => {

	8 assert_selection(

	9 '<div contenteditable><span><a href=\"foo\"><p>^test</p><p>foo<span>bar</spa n>foo<span>bar</span>.\|</p></a></span></div>',
	yosin_UTC9 2016/07/15 02:19:00 nit: No need to escape double quote. This is the r nit: No need to escape double quote. This is the reason why we use single quote in JavaScript.
	10 selection => {
	yosin_UTC9 2016/07/15 02:19:00 nit: You can use short form: ['insertHTML', '<span nit: You can use short form: ['insertHTML', '<span style="color:green">green</span>'] joone 2016/07/15 05:57:52 assert_selection( '<div contenteditable><span> Show quoted text On 2016/07/15 02:19:00, Yosi_UTC9 wrote: > nit: You can use short form: > ['insertHTML', '<span style="color:green">green</span>'] assert_selection( '<div contenteditable><span><a href="foo"><p>^test</p><p>foo<span>bar</span>foo<span>bar</span>.\|</p></a></span></div>', ['insertHTML', '<span style="color:green">green</span>'], '<div contenteditable><span><p><a href="foo"><span style="color:green">green\|</span></a></p></span></div>'); Is this right? it returns an error as follows: This is a testharness.js-based test. FAIL Replace the selected tags with span tags Invalid tester: insertHTML,<span style="color:green">green</span> Harness: the test ran to completion. So I tried to run it as follows: assert_selection( '<div contenteditable><span><a href="foo"><p>^test</p><p>foo<span>bar</span>foo<span>bar</span>.\|</p></a></span></div>', selection => ['insertHTML', '<span style="color:green">green</span>'], '<div contenteditable><span><p><a href="foo"><span style="color:green">green\|</span></a></p></span></div>'); There is no error, but the command doesn't work. yosin_UTC9 2016/07/15 07:06:40 Oops, sorry for confusion. I said wrong thing. We Show quoted text On 2016/07/15 at 05:57:52, joone wrote: > On 2016/07/15 02:19:00, Yosi_UTC9 wrote: > > nit: You can use short form: > > ['insertHTML', '<span style="color:green">green</span>'] > > assert_selection( > '<div contenteditable><span><a href="foo"><p>^test</p><p>foo<span>bar</span>foo<span>bar</span>.\|</p></a></span></div>', > ['insertHTML', '<span style="color:green">green</span>'], > '<div contenteditable><span><p><a href="foo"><span style="color:green">green\|</span></a></p></span></div>'); > > Is this right? it returns an error as follows: > > This is a testharness.js-based test. > FAIL Replace the selected tags with span tags Invalid tester: insertHTML,<span style="color:green">green</span> > Harness: the test ran to completion. > > So I tried to run it as follows: > assert_selection( > '<div contenteditable><span><a href="foo"><p>^test</p><p>foo<span>bar</span>foo<span>bar</span>.\|</p></a></span></div>', > selection => ['insertHTML', '<span style="color:green">green</span>'], > '<div contenteditable><span><p><a href="foo"><span style="color:green">green\|</span></a></p></span></div>'); > > There is no error, but the command doesn't work. Oops, sorry for confusion. I said wrong thing. We could write: assert_selection( '<div contenteditable><span><a href="foo"><p>^test</p><p>foo<span>bar</span>foo<span>bar</span>.\|</p></a></span></div>', 'insertHTML <span style="color:green">green</span>', '<div contenteditable><span><p><a href="foo"><span style="color:green">green\|</span></a></p></span></div>'); Use space separated string instead of array. Here is an implementation of assert_selection: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/editing/a... function assertSelection( inputText, tester, expectedText, opt_description = '') { /** @type {string} */ const description = opt_description === '' ? assembleDescription() : opt_description; checkExpectedText(expectedText); const sample = new Sample(inputText); if (typeof(tester) === 'function') { tester.call(window, sample.selection); } else if (typeof(tester) === 'string') { const strings = tester.split(' '); sample.document.execCommand(strings[0], false, strings[1]); } else { throw new Error(`Invalid tester: ${tester}`); } It used be an array but it was changed to string to be shorter.
	11 selection.document.execCommand('inserthtml', false, '<span style=\"color:g reen\">green</span>');

	12 },

	13 '<div contenteditable><span><p><a href=\"foo\"><span style=\"color:green\">g reen\|</span></a></p></span></div>');
	yosin_UTC9 2016/07/15 02:19:00 nit: No need to escape double quote. This is the r nit: No need to escape double quote. This is the reason why we use single quote in JavaScript.
	14 }, 'Replace the selected tags with span tags');

	15 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »