Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2135933002: [turbofan] Respect pretenuring of heap numbers. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-test-reenable-3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Respect pretenuring of heap numbers. This extends pretenuring decisions based on allocation sites to heap numbers that are allocated as part of object literals. It ensures memory locality of a bigger enclosure of the deep copy of an object literal. R=bmeurer@chromium.org TEST=cctest/test-heap/OptimizedPretenuringMixedInObjectProperties Committed: https://crrev.com/ecfec3b03990c9601b142fa3687eaa64e71c3f61 Cr-Commit-Position: refs/heads/master@{#37645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/compiler/js-create-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 3 chunks +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
Benedikt: PTAL. Michael: FYI.
4 years, 5 months ago (2016-07-11 09:11:12 UTC) #3
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-11 12:57:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135933002/1
4 years, 5 months ago (2016-07-11 14:10:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 14:14:17 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 14:15:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecfec3b03990c9601b142fa3687eaa64e71c3f61
Cr-Commit-Position: refs/heads/master@{#37645}

Powered by Google App Engine
This is Rietveld 408576698