Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2135563003: [turbofan] Enable pretenuring tests for optimized code. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Enable pretenuring tests for optimized code. This enables tests which verify allocation site feedback is used and influences pretenuring decisions. By now TurboFan is respecting such feedback. Ignition however doesn't provide such feedback yet. R=mvstanton@chromium.org Committed: https://crrev.com/7dbc22398333d68c65860f10638c72f988fa1c2c Cr-Commit-Position: refs/heads/master@{#37628}

Patch Set 1 #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -16 lines) Patch
M test/cctest/cctest.status View 1 3 chunks +21 lines, -9 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +20 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
Michael Starzinger
Michael: PTAL. Ross: FYI.
4 years, 5 months ago (2016-07-11 08:16:26 UTC) #2
mvstanton
Awesome drive-down on these disabled tests... here ya go, bots: LGTM
4 years, 5 months ago (2016-07-11 08:18:47 UTC) #3
Benedikt Meurer
Nice, LGTM.
4 years, 5 months ago (2016-07-11 08:20:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135563003/20001
4 years, 5 months ago (2016-07-11 08:34:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 08:39:15 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 08:41:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7dbc22398333d68c65860f10638c72f988fa1c2c
Cr-Commit-Position: refs/heads/master@{#37628}

Powered by Google App Engine
This is Rietveld 408576698