Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2135923002: Storage manager: Update storage usage periodically. (Closed)

Created:
4 years, 5 months ago by fukino
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Storage manager: Update storage usage periodically. To show the up-to-date storage information, this CL modifies storage manager to update the information every 5 seconds while the manager overlay is visible. Also, avoiding updating storage size while computing size is ongoing. BUG=625071 TEST=manually tested CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation TBR=dbeam@chromium.org Review-Url: https://codereview.chromium.org/2137463002 Cr-Commit-Position: refs/heads/master@{#404596} (cherry picked from commit d0938c187331beb68a020bc36d9162c924b7e991) Committed: https://chromium.googlesource.com/chromium/src/+/823118c1f17a653be09c2d79a5b50964aae6f6d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -10 lines) Patch
M chrome/browser/resources/options/chromeos/storage_manager.js View 4 chunks +39 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc View 10 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
4 years, 5 months ago (2016-07-11 08:45:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
823118c1f17a653be09c2d79a5b50964aae6f6d2.

Powered by Google App Engine
This is Rietveld 408576698