Storage manager: Update storage usage periodically.

Storage manager: Update storage usage periodically.

To show the up-to-date storage information, this CL modifies storage manager
to update the information every 5 seconds while the manager overlay is visible.
Also, avoiding updating storage size while computing size is ongoing.

BUG=625071
TEST=manually tested
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d0938c187331beb68a020bc36d9162c924b7e991
Cr-Commit-Position: refs/heads/master@{#404596}

[fukino, 2016-07-08 10:25:12]

Description was changed from

==========
Storage manager: Update storage usage periodically.

To show the up-to-date storage information, this CL modifies storage manager
to update the information every 5 seconds while the manager overlay is visible.
Also, avoiding updating storage size while computing size is ongoing.

BUG=625071
TEST=manually tested
==========

to

==========
Storage manager: Update storage usage periodically.

To show the up-to-date storage information, this CL modifies storage manager
to update the information every 5 seconds while the manager overlay is visible.
Also, avoiding updating storage size while computing size is ongoing.

BUG=625071
TEST=manually tested
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-07-08 10:28:36]

fukino@chromium.org changed reviewers:
+ dbeam@chromium.org

[fukino, 2016-07-08 10:28:37]

Dan, could you take a look?

https://codereview.chromium.org/2137463002/diff/1/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc (left):

https://codereview.chromium.org/2137463002/diff/1/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:387:
web_ui()->CallJavascriptFunctionUnsafe(
As we try to update the Android size every 5 seconds, we can keep it as
"Calculating..." until the arc bridge gets ready.

[Dan Beam, 2016-07-09 00:18:26]

lgtm

https://codereview.chromium.org/2137463002/diff/1/chrome/browser/resources/op...
File chrome/browser/resources/options/chromeos/storage_manager.js (right):

https://codereview.chromium.org/2137463002/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/chromeos/storage_manager.js:47: * @private
nit: @private {number}

https://codereview.chromium.org/2137463002/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/chromeos/storage_manager.js:168: if
(this.updateTimerId_ === -1) {
nit: arguably, you should use == unless there's a Really Good Reason

[fukino, 2016-07-11 03:33:24]

Thank you!

https://codereview.chromium.org/2137463002/diff/1/chrome/browser/resources/op...
File chrome/browser/resources/options/chromeos/storage_manager.js (right):

https://codereview.chromium.org/2137463002/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/chromeos/storage_manager.js:47: * @private
On 2016/07/09 00:18:26, Dan Beam wrote:
> nit: @private {number}

Done.

https://codereview.chromium.org/2137463002/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/chromeos/storage_manager.js:168: if
(this.updateTimerId_ === -1) {
On 2016/07/09 00:18:26, Dan Beam wrote:
> nit: arguably, you should use == unless there's a Really Good Reason

Done for all '===' and '!=='.

[fukino, 2016-07-11 03:33:28]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-07-11 03:33:29]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2137463002/#ps20001
(title: "Use == and !=")

[commit-bot: I haz the power, 2016-07-11 03:33:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 04:21:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-11 04:23:12]

Description was changed from

==========
Storage manager: Update storage usage periodically.

To show the up-to-date storage information, this CL modifies storage manager
to update the information every 5 seconds while the manager overlay is visible.
Also, avoiding updating storage size while computing size is ongoing.

BUG=625071
TEST=manually tested
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Storage manager: Update storage usage periodically.

To show the up-to-date storage information, this CL modifies storage manager
to update the information every 5 seconds while the manager overlay is visible.
Also, avoiding updating storage size while computing size is ongoing.

BUG=625071
TEST=manually tested
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d0938c187331beb68a020bc36d9162c924b7e991
Cr-Commit-Position: refs/heads/master@{#404596}
==========

[commit-bot: I haz the power, 2016-07-11 04:23:13]

Patchset 2 (id:??) landed as
https://crrev.com/d0938c187331beb68a020bc36d9162c924b7e991
Cr-Commit-Position: refs/heads/master@{#404596}