Issue 2135903002: Fix initialization of udev in MidiManagerAlsa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2135903002: Fix initialization of udev in MidiManagerAlsa. (Closed)

Created:
4 years, 5 months ago by Takashi Toyoshima

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix initialization of udev in MidiManagerAlsa. New devices would not be detected on Linux. Worse, things would get very confused if you disconnected one device and connected another. This has been broken for four months, with crrev.com/17cd1b10ded3a5e730bbcb39c57a6d2f8e16a51e BUG=625123 Review-Url: https://codereview.chromium.org/2126023004 Cr-Commit-Position: refs/heads/master@{#404092} (cherry picked from commit e74c2a9687c28f2718d71ae6ad9b6153119361c7) TBR=agoode@chromium.org

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	media/midi/midi_manager_alsa.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Takashi Toyoshima

4 years, 5 months ago (2016-07-11 06:42:43 UTC) #1

Description was changed from

==========
Fix initialization of udev in MidiManagerAlsa.

New devices would not be detected on Linux. Worse,
things would get very confused if you disconnected
one device and connected another.

This has been broken for four months, with
crrev.com/17cd1b10ded3a5e730bbcb39c57a6d2f8e16a51e

BUG=625123

Review-Url: https://codereview.chromium.org/2126023004
Cr-Commit-Position: refs/heads/master@{#404092}
(cherry picked from commit e74c2a9687c28f2718d71ae6ad9b6153119361c7)
==========

to

==========
Fix initialization of udev in MidiManagerAlsa.

New devices would not be detected on Linux. Worse,
things would get very confused if you disconnected
one device and connected another.

This has been broken for four months, with
crrev.com/17cd1b10ded3a5e730bbcb39c57a6d2f8e16a51e

BUG=625123

Review-Url: https://codereview.chromium.org/2126023004
Cr-Commit-Position: refs/heads/master@{#404092}
(cherry picked from commit e74c2a9687c28f2718d71ae6ad9b6153119361c7)

TBR=agoode@chromium.org
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages