Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2126023004: Fix initialization of udev in MidiManagerAlsa. (Closed)

Created:
4 years, 5 months ago by Adam Goode
Modified:
4 years, 5 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix initialization of udev in MidiManagerAlsa. New devices would not be detected on Linux. Worse, things would get very confused if you disconnected one device and connected another. This has been broken for four months, with crrev.com/17cd1b10ded3a5e730bbcb39c57a6d2f8e16a51e BUG=625123 Committed: https://crrev.com/e74c2a9687c28f2718d71ae6ad9b6153119361c7 Cr-Commit-Position: refs/heads/master@{#404092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/midi/midi_manager_alsa.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Adam Goode
4 years, 5 months ago (2016-07-07 02:07:19 UTC) #2
Takashi Toyoshima
Oops! Thank you for catching this. LGTM.
4 years, 5 months ago (2016-07-07 05:38:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126023004/1
4 years, 5 months ago (2016-07-07 05:47:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 06:46:51 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 06:46:55 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 06:49:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e74c2a9687c28f2718d71ae6ad9b6153119361c7
Cr-Commit-Position: refs/heads/master@{#404092}

Powered by Google App Engine
This is Rietveld 408576698