Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2135883002: Fix misplaced guard (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix misplaced guard This fixes an error in https://codereview.chromium.org/2125333002 (Add choke point for modifying non-AA rect draws (e.g., applying clipping)). In GrDrawContext::drawRect, when we need to draw a filled rect, we always want to call drawFilledRect when useDrawInsteadOfClear is false. With the buggy code I believe we were falling back to drawing a path. TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135883002 Committed: https://skia.googlesource.com/skia/+/3ab14ca950d98a5c4d4c4a5f96ea8b0c984e0116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M src/gpu/GrDrawContext.cpp View 1 chunk +25 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135883002/1
4 years, 5 months ago (2016-07-10 18:48:49 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-10 18:49:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3ab14ca950d98a5c4d4c4a5f96ea8b0c984e0116

Powered by Google App Engine
This is Rietveld 408576698