Add choke point for modifying non-AA rect draws (e.g., applying clipping)

Add choke point for modifying non-AA rect draws (e.g., applying clipping)

NOTREECHECKS=true
NOPRESUBMIT=true

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002

Committed: https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9
Committed: https://skia.googlesource.com/skia/+/443023975e335e3630191227dbc21fa72c436af3

[robertphillips, 2016-07-07 16:15:12]

Description was changed from

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)
==========

to

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002
==========

[robertphillips, 2016-07-07 20:43:40]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 20:43:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 21:05:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 21:05:53]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-07-08 14:32:50]

Description was changed from

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002
==========

to

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002
==========

[robertphillips, 2016-07-08 14:32:50]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-07-08 14:33:05]

Ready for review

[bsalomon, 2016-07-08 14:42:09]

lgtm w/ suggestion

https://codereview.chromium.org/2125333002/diff/80001/src/gpu/GrDrawContext.cpp
File src/gpu/GrDrawContext.cpp (right):

https://codereview.chromium.org/2125333002/diff/80001/src/gpu/GrDrawContext.c...
src/gpu/GrDrawContext.cpp:318: return false;
just wondering if this could be

if (instanced rendering) {
  batch.reset(skljfkdls);
} else if (should_apply_stuff) {
  batch.reset(klasdjfkldasjf);
} else {
  this->drawNonAAFilledRect();
  return true;
}

if (!batch) {
    return false;
}

GrPipelineBuilder pipelineBuilder(paint, useHWAA);
if (ss) {
    pipelineBuilder.setUserStencil(ss);
}
this->getDrawTarget()->drawBatch(pipelineBuilder, this, clip, batch);
return true;


Just to consolidate the screwy pb/ss stuff.

[robertphillips, 2016-07-08 16:40:32]

https://codereview.chromium.org/2125333002/diff/80001/src/gpu/GrDrawContext.cpp
File src/gpu/GrDrawContext.cpp (right):

https://codereview.chromium.org/2125333002/diff/80001/src/gpu/GrDrawContext.c...
src/gpu/GrDrawContext.cpp:318: return false;
On 2016/07/08 14:42:09, bsalomon wrote:
> just wondering if this could be
> 
> if (instanced rendering) {
>   batch.reset(skljfkdls);
> } else if (should_apply_stuff) {
>   batch.reset(klasdjfkldasjf);
> } else {
>   this->drawNonAAFilledRect();
>   return true;
> }
> 
> if (!batch) {
>     return false;
> }
> 
> GrPipelineBuilder pipelineBuilder(paint, useHWAA);
> if (ss) {
>     pipelineBuilder.setUserStencil(ss);
> }
> this->getDrawTarget()->drawBatch(pipelineBuilder, this, clip, batch);
> return true;
> 
> 
> Just to consolidate the screwy pb/ss stuff.

Unfortunately, I believe the instanced rendering stuff wants to fall through to
the normal path if it fails so it doesn't wind up being that pretty.

[robertphillips, 2016-07-08 16:40:38]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-07-08 16:40:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-07-08 18:32:42]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 18:32:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-07-08 18:33:13]

Description was changed from

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002
==========

to

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)

NOTREECHECKS=true
NOPRESUBMIT=true

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002
==========

[commit-bot: I haz the power, 2016-07-08 18:52:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 18:52:23]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-07-08 18:58:33]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-07-08 18:58:33]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2125333002/#ps100001
(title: "update to ToT")

[commit-bot: I haz the power, 2016-07-08 18:58:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 19:00:10]

Description was changed from

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)

NOTREECHECKS=true
NOPRESUBMIT=true

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002
==========

to

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)

NOTREECHECKS=true
NOPRESUBMIT=true

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002

Committed:
https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9
==========

[commit-bot: I haz the power, 2016-07-08 19:00:11]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9

[commit-bot: I haz the power, 2016-07-08 19:00:15]

CQ bit was unchecked.

[robertphillips, 2016-07-08 20:29:52]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2136643002/ by robertphillips@google.com.

The reason for reverting is: problems.

[robertphillips, 2016-07-08 20:39:57]

Description was changed from

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)

NOTREECHECKS=true
NOPRESUBMIT=true

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002

Committed:
https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9
==========

to

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)

NOTREECHECKS=true
NOPRESUBMIT=true

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002

Committed:
https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9
==========

[robertphillips, 2016-07-08 20:40:03]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 20:40:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 21:01:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 21:01:27]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-07-08 21:42:43]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-07-08 21:42:44]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2125333002/#ps120001
(title: "Fix infinite optimization loop")

[commit-bot: I haz the power, 2016-07-08 21:42:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 21:43:07]

Description was changed from

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)

NOTREECHECKS=true
NOPRESUBMIT=true

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002

Committed:
https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9
==========

to

==========
Add choke point for modifying non-AA rect draws (e.g., applying clipping)

NOTREECHECKS=true
NOPRESUBMIT=true

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002

Committed:
https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9
Committed:
https://skia.googlesource.com/skia/+/443023975e335e3630191227dbc21fa72c436af3
==========

[commit-bot: I haz the power, 2016-07-08 21:43:07]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/443023975e335e3630191227dbc21fa72c436af3