Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2135753003: Revert of webgl: use immutable texture for the default FBO. (Closed)

Created:
4 years, 5 months ago by Corentin Wallez
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of webgl: use immutable texture for the default FBO. (patchset #2 id:20001 of https://codereview.chromium.org/1449043005/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=626742 BUG=626742 Original issue's description: > webgl: use immutable texture for the default FBO. > > Use immutable texture for the default FBO like chromium compositor. > > In theory, it speeds up drawing speed, because immutable texture skips texture > validation on drawing call. > > In addition, immutable texture allows GL_INTEL_framebuffer_CMAA more optimization. > > BUG=557848 > TEST= > WebglConformance.conformance_renderbuffers_framebuffer_state_restoration > WebglConformance.conformance_textures_misc_texture_size_cube_maps > WebglConformance.conformance_textures_misc_texture_sub_image_cube_maps > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_byte > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_short_5_6_5 > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_byte > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_4_4_4_4 > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_5_5_5_1 > > Committed: https://crrev.com/fb9d8e245ac84c6c0806e86e7884b4775a84b4b5 > Cr-Commit-Position: refs/heads/master@{#361335} TBR=kbr@chromium.org,adrian.belgun@intel.com,dongseong.hwang@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=557848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 5 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Corentin Wallez
Created Revert of webgl: use immutable texture for the default FBO.
4 years, 5 months ago (2016-07-08 21:23:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135753003/1
4 years, 5 months ago (2016-07-08 21:24:02 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 21:27:45 UTC) #6
Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Powered by Google App Engine
This is Rietveld 408576698